Re: [GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

[Matt Foley <ma...@apache.org>]

Hi Justin,
If you change the maven invocation to build the site-book, please also change the README at https://github.com/apache/incubator-metron/tree/master/site-book

And is the new invocation done from <base dir>/site-book/ as previously, or from base dir?

Thanks,
--Matt

On 4/30/17, 6:12 AM, "justinleet" <gi...@git.apache.org> wrote:

    Github user justinleet commented on the issue:
    
        https://github.com/apache/incubator-metron/pull/459
      
        Ran this up for a little while in down time over the last couple days. These counts include the previous updates (so 2 additional failures and 15 successes, and 1 additional failure and 25 successes for this branch). In both cases, the additional error was the PcapTopologyIntegrationTest test.  I'll add in 1 failure for this branch since I had to kick the Travis build.
        
        Master:
        6 BUILD FAILURE
        23 BUILD SUCCESS
        
        Branch
        2 BUILD FAILURE
        42 BUILD SUCCESS
        
        At this point, I think this satisfies the criteria of not being worse than master.
        
        I've also run up full dev again (since there've been a few things changed and cleaned up, and so on), and data flowed through as expected.
        
        I did make another change.  I was spinning up the site-book, but not running the generate-md.sh.  I added it to pre-site portion of the lifecycle.  Admittedly, this does mean that running the site itself requires bash, but it seems like a reasonable requirement (particularly since this is only for the site).
        
        At this point, that does change the test run slightly: It's `mvn clean install site site:deploy site:stage-deploy` (instead of site:site, it should be just plain site to ensure site:pre-site is run).  Tests can be skipped with -DskipTests and code coverage simply won't run (and won't appear in the reports).
    
    
    ---
    If your project is set up for it, you can reply to this email and have your
    reply appear on GitHub as well. If your project does not have this feature
    enabled and wishes so, or if the feature is enabled but not working, please
    contact infrastructure at infrastructure@apache.org or file a JIRA ticket
    with INFRA.
    ---