You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@spamassassin.apache.org by Justin Mason <jm...@jmason.org> on 2007/10/20 02:23:47 UTC

Re: svn commit: r586641 - /spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm

mmartinec@apache.org writes:
> Author: mmartinec
> Date: Fri Oct 19 16:28:34 2007
> New Revision: 586641
> 
> URL: http://svn.apache.org/viewvc?rev=586641&view=rev
> Log:
> replace experimental and broken utf8::downgrade() with encode("utf8"), Bug 5691
> 
> Modified:
>     spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm
> 
> Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm
> URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm?rev=586641&r1=586640&r2=586641&view=diff
> ==============================================================================
> --- spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm (original)
> +++ spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm Fri Oct 19 16:28:34 2007
> @@ -43,6 +43,8 @@
>  use Mail::SpamAssassin::HTML;
>  use Mail::SpamAssassin::Logger;
>  
> +use Encode;
> +

http://buildbot.spamassassin.org:8010/t-feisty-561/builds/275/step-compile/0

indicates that Encode is not available on perl 5.6.1.

--j.

Re: svn commit: r586641 - /spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm

Posted by Michael Parker <pa...@pobox.com>.

Mark Martinec wrote:
>>> +use Encode;
>> indicates that Encode is not available on perl 5.6.1.
> 
> ... but its routines are already used in Message/Node.pm !?
> 
> Mark
> 

Aren't they wrapped around a conditional?  -1 for requiring Encode.

We've had this discussion before.

Michael

Re: svn commit: r586641 - /spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm

Posted by Mark Martinec <Ma...@ijs.si>.

> > +use Encode;
> indicates that Encode is not available on perl 5.6.1.

... but its routines are already used in Message/Node.pm !?

Mark