[jira] [Comment Edited] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626724#comment-17626724 ] 

David Capwell edited comment on CASSANDRA-17199 at 10/31/22 5:53 PM:
---------------------------------------------------------------------

This visibility would also be a nice addition to org.apache.cassandra.db.virtual.StreamingVirtualTable; adding to the vtable as a list/set of failed peers can be easier than parsing logs.


was (Author: dcapwell):
This visibility would also be a nice addition to org.apache.cassandra.db.virtual.StreamingVirtualTable; adding to the vtable as a list/set of failed session can be easier than parsing logs.

> Provide summary of failed SessionInfo's in StreamResultFuture
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-17199
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17199
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability/Logging
>            Reporter: Brendan Cicchi
>            Priority: Normal
>              Labels: AdventCalendar2021, lhf
>             Fix For: 4.0.x
>
>
> Currently, we warn about the presence of one or more failed sessions existing in the final state and then an operator/user traces back through the logs to find any failed streams for troubleshooting.
> {code:java}
> private synchronized void maybeComplete()
> {
>     if (finishedAllSessions())
>     {
>         StreamState finalState = getCurrentState();
>         if (finalState.hasFailedSession())
>         {
>             logger.warn("[Stream #{}] Stream failed", planId);
>             tryFailure(new StreamException(finalState, "Stream failed"));
>         }
>         else
>         {
>             logger.info("[Stream #{}] All sessions completed", planId);
>             trySuccess(finalState);
>         }
>     }
> } {code}
> It would be helpful to log out a summary of the SessionInfo for each failed session since that should be accessible via the StreamState.
>  
> This can be especially helpful for longer streaming operations like bootstrap where the failure could have been a long time back and all recent streams leading up to the warning actually are successful.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org