You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/04 05:10:43 UTC
[GitHub] [pulsar] srkukarni opened a new pull request #7165: Attach names for all producers/readers in worker service
srkukarni opened a new pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
This pr attaches names for all the producers/readers that worker service utilizes. This is very useful for debugging.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#issuecomment-638651475
@srkukarni that is the place. I must have missed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#discussion_r435624610
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
##########
@@ -106,6 +106,7 @@ public SchedulerManager(WorkerConfig workerConfig, PulsarClient pulsarClient, Pu
.blockIfQueueFull(true)
.compressionType(CompressionType.LZ4)
.sendTimeout(0, TimeUnit.MILLISECONDS)
+ .producerName(config.getWorkerId() + "-scheduler-manager")
Review comment:
Producer name needs to be unique, so we better put this in the producer properties instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#issuecomment-638606756
@srkukarni can you also add for the producer in the FunctionMetadataManager
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#discussion_r434997005
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
##########
@@ -91,6 +91,7 @@ public void initialize() {
Reader<byte[]> reader = pulsarClient.newReader()
.topic(this.workerConfig.getFunctionMetadataTopic())
.startMessageId(MessageId.earliest)
+ .readerName(workerConfig.getWorkerId() + "-function-metadata-manager")
Review comment:
I don't know if its needed to add "-function-metadata-manager". I would say that this information as a property e.g. component: function-metadata-manager but properties is not exposed for the reader
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#discussion_r435692495
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
##########
@@ -91,6 +91,7 @@ public void initialize() {
Reader<byte[]> reader = pulsarClient.newReader()
.topic(this.workerConfig.getFunctionMetadataTopic())
.startMessageId(MessageId.earliest)
+ .readerName(workerConfig.getWorkerId() + "-function-metadata-manager")
Review comment:
I meant to add it here
```
can you also add
.subscriptionRolePrefix(workerConfig.getWorkerId())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
srkukarni commented on pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#issuecomment-638607193
@jerrypeng Its already added.
https://github.com/apache/pulsar/pull/7165/files#diff-e583d3ebd03ff417566e9ecadda7c3a7R436
Or is there other place that you have in mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni merged pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
srkukarni merged pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on a change in pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
srkukarni commented on a change in pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#discussion_r435002727
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
##########
@@ -91,6 +91,7 @@ public void initialize() {
Reader<byte[]> reader = pulsarClient.newReader()
.topic(this.workerConfig.getFunctionMetadataTopic())
.startMessageId(MessageId.earliest)
+ .readerName(workerConfig.getWorkerId() + "-function-metadata-manager")
Review comment:
I would rather prefer it to be more specific than just assumed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#discussion_r435471035
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
##########
@@ -106,6 +106,7 @@ public SchedulerManager(WorkerConfig workerConfig, PulsarClient pulsarClient, Pu
.blockIfQueueFull(true)
.compressionType(CompressionType.LZ4)
.sendTimeout(0, TimeUnit.MILLISECONDS)
+ .producerName(config.getWorkerId() + "-scheduler-manager")
Review comment:
can you also add
.subscriptionRolePrefix(workerConfig.getWorkerId())
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #7165: Attach names for all producers/readers in worker service
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#discussion_r435624935
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
##########
@@ -106,6 +106,7 @@ public SchedulerManager(WorkerConfig workerConfig, PulsarClient pulsarClient, Pu
.blockIfQueueFull(true)
.compressionType(CompressionType.LZ4)
.sendTimeout(0, TimeUnit.MILLISECONDS)
+ .producerName(config.getWorkerId() + "-scheduler-manager")
Review comment:
Actually, in this case it should be good since there's only 1 writer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org