You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/07/22 18:36:22 UTC
Review Request 36695: GEODE-148: change expiration tests to not run
so long
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36695/
-----------------------------------------------------------
Review request for geode and Kirk Lund.
Repository: geode
Description
-------
The following tests have been improved to not run so long and to not have intermittent failures.
One general change is to no longer wait for the actual expiration to happen but instead check the EntryExpiryTask
to see if the expiration time it reports changed.
- testEntryTtl3
- testEntryIdleTimeout3
- testCustomEntryIdleTimeout3
- testEntryIdleTtl
- testRegionIdleInvalidate
- testUpdateResetsIdleTime
- testEntryIdleReset
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java 1dcd9184580f1a6fd8e04283897727ff3aef2f4b
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 4e1f64bc952e4fb28cd39be14973538074f25d18
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java eab46abd2cf683a4715177445903053101da309e
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 003b69157fc2d02b8f6ec9e506f500dfa0c04a26
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java 30d839a26faa7ba6b3ba88bbbe8090c316a0d61c
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionTTLExpiryTask.java 909af7dd895bfca83958448fb2e5aa5398371446
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java dfbc82d7939a923d989233077b66f4de4e23c67f
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java c24791ba5187b26bba2e5cc370d71690b5070b42
gemfire-core/src/test/java/dunit/DistributedTestCase.java e6f0941893e41cc3da12d70a99fa527c851efe73
Diff: https://reviews.apache.org/r/36695/diff/
Testing
-------
precheckin
Thanks,
Darrel Schneider
Re: Review Request 36695: GEODE-148: change expiration tests to not
run so long
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36695/#review92927
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On July 22, 2015, 4:36 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36695/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 4:36 p.m.)
>
>
> Review request for geode and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The following tests have been improved to not run so long and to not have intermittent failures.
> One general change is to no longer wait for the actual expiration to happen but instead check the EntryExpiryTask
> to see if the expiration time it reports changed.
> - testEntryTtl3
> - testEntryIdleTimeout3
> - testCustomEntryIdleTimeout3
> - testEntryIdleTtl
> - testRegionIdleInvalidate
> - testUpdateResetsIdleTime
> - testEntryIdleReset
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java 1dcd9184580f1a6fd8e04283897727ff3aef2f4b
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 4e1f64bc952e4fb28cd39be14973538074f25d18
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java eab46abd2cf683a4715177445903053101da309e
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 003b69157fc2d02b8f6ec9e506f500dfa0c04a26
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java 30d839a26faa7ba6b3ba88bbbe8090c316a0d61c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionTTLExpiryTask.java 909af7dd895bfca83958448fb2e5aa5398371446
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java dfbc82d7939a923d989233077b66f4de4e23c67f
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java c24791ba5187b26bba2e5cc370d71690b5070b42
> gemfire-core/src/test/java/dunit/DistributedTestCase.java e6f0941893e41cc3da12d70a99fa527c851efe73
>
> Diff: https://reviews.apache.org/r/36695/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 36695: GEODE-148: change expiration tests to not
run so long
Posted by Darrel Schneider <ds...@pivotal.io>.
> On July 23, 2015, 2:40 p.m., Kirk Lund wrote:
> > gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java, line 3851
> > <https://reviews.apache.org/r/36695/diff/1/?file=1018863#file1018863line3851>
> >
> > Did you mean to leave the TODO here?
Yes. I'm not sure what other operations should be validated here so this was a reminder to improve this test.
- Darrel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36695/#review92821
-----------------------------------------------------------
On July 22, 2015, 9:36 a.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36695/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 9:36 a.m.)
>
>
> Review request for geode and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The following tests have been improved to not run so long and to not have intermittent failures.
> One general change is to no longer wait for the actual expiration to happen but instead check the EntryExpiryTask
> to see if the expiration time it reports changed.
> - testEntryTtl3
> - testEntryIdleTimeout3
> - testCustomEntryIdleTimeout3
> - testEntryIdleTtl
> - testRegionIdleInvalidate
> - testUpdateResetsIdleTime
> - testEntryIdleReset
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java 1dcd9184580f1a6fd8e04283897727ff3aef2f4b
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 4e1f64bc952e4fb28cd39be14973538074f25d18
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java eab46abd2cf683a4715177445903053101da309e
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 003b69157fc2d02b8f6ec9e506f500dfa0c04a26
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java 30d839a26faa7ba6b3ba88bbbe8090c316a0d61c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionTTLExpiryTask.java 909af7dd895bfca83958448fb2e5aa5398371446
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java dfbc82d7939a923d989233077b66f4de4e23c67f
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java c24791ba5187b26bba2e5cc370d71690b5070b42
> gemfire-core/src/test/java/dunit/DistributedTestCase.java e6f0941893e41cc3da12d70a99fa527c851efe73
>
> Diff: https://reviews.apache.org/r/36695/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 36695: GEODE-148: change expiration tests to not
run so long
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36695/#review92821
-----------------------------------------------------------
Ship it!
Ship It!
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java (line 3617)
<https://reviews.apache.org/r/36695/#comment147062>
Did you mean to leave the TODO here?
- Kirk Lund
On July 22, 2015, 4:36 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36695/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 4:36 p.m.)
>
>
> Review request for geode and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The following tests have been improved to not run so long and to not have intermittent failures.
> One general change is to no longer wait for the actual expiration to happen but instead check the EntryExpiryTask
> to see if the expiration time it reports changed.
> - testEntryTtl3
> - testEntryIdleTimeout3
> - testCustomEntryIdleTimeout3
> - testEntryIdleTtl
> - testRegionIdleInvalidate
> - testUpdateResetsIdleTime
> - testEntryIdleReset
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegion.java 1dcd9184580f1a6fd8e04283897727ff3aef2f4b
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/ExpiryTask.java 4e1f64bc952e4fb28cd39be14973538074f25d18
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java eab46abd2cf683a4715177445903053101da309e
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java 003b69157fc2d02b8f6ec9e506f500dfa0c04a26
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionIdleExpiryTask.java 30d839a26faa7ba6b3ba88bbbe8090c316a0d61c
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionTTLExpiryTask.java 909af7dd895bfca83958448fb2e5aa5398371446
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java dfbc82d7939a923d989233077b66f4de4e23c67f
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/RegionTestCase.java c24791ba5187b26bba2e5cc370d71690b5070b42
> gemfire-core/src/test/java/dunit/DistributedTestCase.java e6f0941893e41cc3da12d70a99fa527c851efe73
>
> Diff: https://reviews.apache.org/r/36695/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Darrel Schneider
>
>