You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/10 15:21:18 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #6170: Python: Move FileIO initialization to the catalog
Fokko opened a new pull request, #6170:
URL: https://github.com/apache/iceberg/pull/6170
Follow up on: https://github.com/apache/iceberg/pull/6161#discussion_r1018547445
Another option is to move it to the constructor of the Table and not store the properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6170: Python: Move FileIO initialization to the catalog
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6170:
URL: https://github.com/apache/iceberg/pull/6170#issuecomment-1310637803
Looks good to me! Just needs to be rebased and we can get it in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6170: Python: Move FileIO initialization to the catalog
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6170:
URL: https://github.com/apache/iceberg/pull/6170#discussion_r1019421535
##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -162,6 +163,9 @@ def __init__(self, name: str, **properties: str):
self.name = name
self.properties = properties
+ def _load_file_io(self, properties: Properties = EMPTY_DICT) -> FileIO:
+ return load_file_io({**self.properties, **properties})
Review Comment:
I don't think that we include table properties in the JVM version, but this seems like a good idea to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #6170: Python: Move FileIO initialization to the catalog
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #6170:
URL: https://github.com/apache/iceberg/pull/6170#issuecomment-1310735121
Thanks @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #6170: Python: Move FileIO initialization to the catalog
Posted by GitBox <gi...@apache.org>.
Fokko merged PR #6170:
URL: https://github.com/apache/iceberg/pull/6170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org