You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/25 19:49:33 UTC
[kudu-CR] Change TabletHistoryGCITest back to manual flushes
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5224
Change subject: Change TabletHistoryGCITest back to manual flushes
......................................................................
Change TabletHistoryGCITest back to manual flushes
Mike found a potential problem with client flushes when there are
concurrent manual and automatic flushes going on (KUDU-1761). Until
we address that this changes this test back to MANUAL_FLUSH with
a single flush at the end of each batch.
This change makes the test non-flaky (ran dist-test on a follow
up patch).
Change-Id: Ibf89a8b113f347a274aa59e59e0d8b7ebcb6f2f0
---
M src/kudu/integration-tests/tablet_history_gc-itest.cc
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/5224/1
--
To view, visit http://gerrit.cloudera.org:8080/5224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf89a8b113f347a274aa59e59e0d8b7ebcb6f2f0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Change TabletHistoryGCITest back to manual flushes
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Change TabletHistoryGCITest back to manual flushes
......................................................................
Change TabletHistoryGCITest back to manual flushes
Mike found a potential problem with client flushes when there are
concurrent manual and automatic flushes going on (KUDU-1761). Until
we address that this changes this test back to MANUAL_FLUSH with
a single flush at the end of each batch.
This change makes the test non-flaky (ran dist-test on a follow
up patch).
Change-Id: Ibf89a8b113f347a274aa59e59e0d8b7ebcb6f2f0
Reviewed-on: http://gerrit.cloudera.org:8080/5224
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/tablet_history_gc-itest.cc
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf89a8b113f347a274aa59e59e0d8b7ebcb6f2f0
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Change TabletHistoryGCITest back to manual flushes
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Change TabletHistoryGCITest back to manual flushes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5224
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf89a8b113f347a274aa59e59e0d8b7ebcb6f2f0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No