You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/08/06 06:46:43 UTC
[PR] chore(frontend): remove the disabled CollabWrapperComponent [texera]
aglinxinyuan opened a new pull request, #7351:
URL: https://github.com/apache/texera/pull/7351
### What changes were proposed in this PR?
`CollabWrapperComponent` **cannot be instantiated**. It is wired in, but nothing reaches it:
```
app.module.ts declares CollabWrapperComponent
formly-config.ts registers it as wrapper "collab-wrapper"
│
└── who applies the name "collab-wrapper" to a field?
only CollabWrapperComponent.setupFieldConfig (inside the component's own file)
└── its only caller, in operator-property-edit-frame, is COMMENTED OUT
```
It is currently the largest uncovered frontend file at **6.8% of 73 lines**.
**Please read this as a proposal, not a routine cleanup.** The caller was disabled deliberately:
> `// TODO: we temporarily disable this due to Yjs update causing issues in Formly.`
I am not treating "temporarily" as decisive, for these reasons:
| Evidence | |
|---|---|
| the disabling predates the Oct 2025 `core/gui` relocation | off for well over a year |
| Angular 19 upgrade (#4445) | mechanical |
| standalone-components refactor (#4873) | mechanical |
| dependabot `y-quill` 0.1.5 → 1.0.0 (#6418) | keeping a dependency current for code that never runs |
Nobody has worked on the feature itself since it was switched off — it has only been carried along by upgrades. But if the intent to restore is still live, **say so and I will close this**. The implementation is one `git revert` away, and the sibling `PresetWrapperComponent.setupFieldConfig` is still in use at `operator-property-edit-frame.component.ts:1084`, so the pattern to rebuild from remains in the tree either way.
**Removed:** the component with its template and styles, the `app.module` import and declaration, the `formly-config` import and wrapper registration, and the commented-out caller that referenced the deleted class.
**One knock-on, handled explicitly.** `operator-property-edit-frame.component.spec.ts` imported `COLLAB_DEBOUNCE_TIME_MS` from the component — but only as a `tick()` duration during fixture setup, before the change under test, and unrelated to the debounce its assertions actually wait on (`FORM_DEBOUNCE_TIME_MS`, 150ms). It was an incidental borrow of a convenient `10`. Replaced with a locally named `SETUP_FLUSH_MS = 10`, so behaviour is byte-identical and the intent is now stated where it is used.
**No `package.json` change.** `quill`, `y-quill` and `quill-cursors` look like they should go with it, but they do not: `operator-property-edit-frame` and `port-property-edit-frame` both still use all three.
### Any related issues, documentation, discussions?
Closes #7350
### How was this PR tested?
Deletions need proof that nothing else depended on the removed code, so:
```
npx tsc --noEmit -p tsconfig.json -> exit 0, 0 errors across the whole app
```
```
npx ng test --watch=false --include="**/formly-config.spec.ts" --include="**/operator-property-edit-frame.component.spec.ts"
✓ src/app/common/formly/formly-config.spec.ts (11 tests)
✓ .../operator-property-edit-frame.component.spec.ts (195 tests | 1 skipped)
Test Files 2 passed (2)
```
Those two specs are the ones that actually exercise the touched wiring — `formly-config.spec` covers the wrapper registry, and the other is the spec whose import changed. `yarn format:ci` passes; it flagged `formly-config.ts` on the first attempt, since removing the entry changed the array's wrapping.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the disabled CollabWrapperComponent [texera]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #7351:
URL: https://github.com/apache/texera/pull/7351#discussion_r3726526003
##########
frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.spec.ts:
##########
@@ -30,6 +30,13 @@ import { CustomJSONSchema7 } from "../../../types/custom-json-schema.interface";
import { OperatorMetadataService } from "../../../service/operator-metadata/operator-metadata.service";
import { StubOperatorMetadataService } from "../../../service/operator-metadata/stub-operator-metadata.service";
import { FORM_DEBOUNCE_TIME_MS } from "../../../service/execute-workflow/execute-workflow.service";
+
+/**
+ * Drains the short timers scheduled while the fixture is being set up, before the form change
+ * under test. Unrelated to FORM_DEBOUNCE_TIME_MS, which is what the assertions below actually wait
+ * on; this previously borrowed COLLAB_DEBOUNCE_TIME_MS (also 10ms) from an unrelated component.
+ */
+const SETUP_FLUSH_MS = 10;
import { DatePipe } from "@angular/common";
Review Comment:
`SETUP_FLUSH_MS` is declared between import statements. Keeping all imports contiguous (and defining module constants after the import block) makes the file easier to scan and avoids issues with tooling that assumes imports come first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the disabled CollabWrapperComponent [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7351:
URL: https://github.com/apache/texera/pull/7351#issuecomment-5657813929
This pull request has been automatically marked as **stale** because it has
not had any activity for 30 days. It will be closed in **7 days** if no
further activity occurs.
If this PR is still relevant, please:
- Push new commits or rebase onto the latest `main`, or
- Comment with a status update, or
- Address any open review feedback.
To exempt this PR from auto-close, a maintainer can add the `pinned` label.
Thank you for your contribution to Apache Texera (incubating)!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the disabled CollabWrapperComponent [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7351:
URL: https://github.com/apache/texera/pull/7351#issuecomment-5210194649
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7351?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.84%. Comparing base ([`cc83087`](https://app.codecov.io/gh/apache/texera/commit/cc8308740361324f7f129657dad6dc395abeeb1c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`60c6416`](https://app.codecov.io/gh/apache/texera/commit/60c641636c016ec3b23b9df20d1db1a1198c008d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7351 +/- ##
============================================
+ Coverage 83.72% 83.84% +0.12%
Complexity 4137 4137
============================================
Files 1169 1167 -2
Lines 46520 46444 -76
Branches 5179 5164 -15
============================================
- Hits 38947 38941 -6
+ Misses 5860 5791 -69
+ Partials 1713 1712 -1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.65% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.66% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.72% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.97% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.05% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.00% <ø> (+0.28%)` | :arrow_up: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.89% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `97.36% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | Carriedforward from [fb9e593](https://app.codecov.io/gh/apache/texera/commit/fb9e59303143cda7fd4a30e84c8e7e78d54b0cb6?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7351?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the disabled CollabWrapperComponent [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7351: chore(frontend): remove the disabled CollabWrapperComponent
URL: https://github.com/apache/texera/pull/7351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the disabled CollabWrapperComponent [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7351:
URL: https://github.com/apache/texera/pull/7351#issuecomment-5754284155
This pull request has been automatically closed due to 37 days of inactivity.
If you would like to continue this work, please re-open the PR or open a new
one referencing this. Thank you for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the disabled CollabWrapperComponent [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7351:
URL: https://github.com/apache/texera/pull/7351#issuecomment-5201343171
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@rbelavadi`, `@zyratlo`, `@ELin2025`
You can notify them by mentioning `@rbelavadi`, `@zyratlo`, `@ELin2025` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove the disabled CollabWrapperComponent [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #7351:
URL: https://github.com/apache/texera/pull/7351#discussion_r3739643382
##########
frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.spec.ts:
##########
@@ -30,6 +30,13 @@ import { CustomJSONSchema7 } from "../../../types/custom-json-schema.interface";
import { OperatorMetadataService } from "../../../service/operator-metadata/operator-metadata.service";
import { StubOperatorMetadataService } from "../../../service/operator-metadata/stub-operator-metadata.service";
import { FORM_DEBOUNCE_TIME_MS } from "../../../service/execute-workflow/execute-workflow.service";
+
+/**
+ * Drains the short timers scheduled while the fixture is being set up, before the form change
+ * under test. Unrelated to FORM_DEBOUNCE_TIME_MS, which is what the assertions below actually wait
+ * on; this previously borrowed COLLAB_DEBOUNCE_TIME_MS (also 10ms) from an unrelated component.
+ */
+const SETUP_FLUSH_MS = 10;
import { DatePipe } from "@angular/common";
Review Comment:
Agreed — moved in 60c641636c. `SETUP_FLUSH_MS` now sits below the import block rather than between two import statements.
It landed there because it replaced an import: the constant used to be `COLLAB_DEBOUNCE_TIME_MS`, pulled in from the component this PR deletes, and defining it in place kept the diff small. That was the wrong tradeoff for a line that stays in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org