You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sirona.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2014/02/18 07:42:54 UTC
Re: svn commit: r1569201 - /incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
Hi
pretty sure we'll need to pool UUID to get them prepare as much as
possible (or get an IdFactory to let it be configurable), wdyt?
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-02-18 6:59 GMT+01:00 <ol...@apache.org>:
> Author: olamy
> Date: Tue Feb 18 05:59:35 2014
> New Revision: 1569201
>
> URL: http://svn.apache.org/r1569201
> Log:
> back to UUID usage
>
> Modified:
> incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
>
> Modified: incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
> URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java?rev=1569201&r1=1569200&r2=1569201&view=diff
> ==============================================================================
> --- incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java (original)
> +++ incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java Tue Feb 18 05:59:35 2014
> @@ -16,6 +16,8 @@
> */
> package org.apache.sirona.tracking;
>
> +import java.util.UUID;
> +
> /**
> * @author Olivier Lamy
> */
> @@ -24,13 +26,14 @@ public class PathTrackingThreadLocal
>
> private static final boolean DEBUG = Boolean.getBoolean( "sirona.agent.debug" );
>
> +
> //private static final InheritableThreadLocal<String> THREAD_LOCAL = new InheritableThreadLocal<String>()
> private static final ThreadLocal<String> THREAD_LOCAL = new ThreadLocal<String>()
> {
> @Override
> protected String initialValue()
> {
> - return "Sirona-" + System.nanoTime();// + UUID.randomUUID().toString();
> + return "Sirona-" + UUID.randomUUID().toString();// + System.nanoTime();//
> }
>
> /*
>
>
Re: svn commit: r1569201 - /incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
Posted by Romain Manni-Bucau <rm...@gmail.com>.
well maybe not pool but prebuilt uuid in an async thread, it is VERY
slow to generate them. (sorry pool was wrong in my previous mail)
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-02-18 13:22 GMT+01:00 Olivier Lamy <ol...@apache.org>:
> On 18 February 2014 17:42, Romain Manni-Bucau <rm...@gmail.com> wrote:
>> Hi
>>
>> pretty sure we'll need to pool UUID to get them prepare as much as
>> possible (or get an IdFactory to let it be configurable), wdyt?
>
> Maybe but not sure it's really resources consuming compared to adding
> a pool which will need extra code to pass tru and maybe some sync
> ?
>
>> Romain Manni-Bucau
>> Twitter: @rmannibucau
>> Blog: http://rmannibucau.wordpress.com/
>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>> Github: https://github.com/rmannibucau
>>
>>
>>
>> 2014-02-18 6:59 GMT+01:00 <ol...@apache.org>:
>>> Author: olamy
>>> Date: Tue Feb 18 05:59:35 2014
>>> New Revision: 1569201
>>>
>>> URL: http://svn.apache.org/r1569201
>>> Log:
>>> back to UUID usage
>>>
>>> Modified:
>>> incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
>>>
>>> Modified: incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
>>> URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java?rev=1569201&r1=1569200&r2=1569201&view=diff
>>> ==============================================================================
>>> --- incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java (original)
>>> +++ incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java Tue Feb 18 05:59:35 2014
>>> @@ -16,6 +16,8 @@
>>> */
>>> package org.apache.sirona.tracking;
>>>
>>> +import java.util.UUID;
>>> +
>>> /**
>>> * @author Olivier Lamy
>>> */
>>> @@ -24,13 +26,14 @@ public class PathTrackingThreadLocal
>>>
>>> private static final boolean DEBUG = Boolean.getBoolean( "sirona.agent.debug" );
>>>
>>> +
>>> //private static final InheritableThreadLocal<String> THREAD_LOCAL = new InheritableThreadLocal<String>()
>>> private static final ThreadLocal<String> THREAD_LOCAL = new ThreadLocal<String>()
>>> {
>>> @Override
>>> protected String initialValue()
>>> {
>>> - return "Sirona-" + System.nanoTime();// + UUID.randomUUID().toString();
>>> + return "Sirona-" + UUID.randomUUID().toString();// + System.nanoTime();//
>>> }
>>>
>>> /*
>>>
>>>
>
>
>
> --
> Olivier Lamy
> Ecetera: http://ecetera.com.au
> http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: svn commit: r1569201 - /incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
Posted by Olivier Lamy <ol...@apache.org>.
On 18 February 2014 17:42, Romain Manni-Bucau <rm...@gmail.com> wrote:
> Hi
>
> pretty sure we'll need to pool UUID to get them prepare as much as
> possible (or get an IdFactory to let it be configurable), wdyt?
Maybe but not sure it's really resources consuming compared to adding
a pool which will need extra code to pass tru and maybe some sync
?
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
>
> 2014-02-18 6:59 GMT+01:00 <ol...@apache.org>:
>> Author: olamy
>> Date: Tue Feb 18 05:59:35 2014
>> New Revision: 1569201
>>
>> URL: http://svn.apache.org/r1569201
>> Log:
>> back to UUID usage
>>
>> Modified:
>> incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
>>
>> Modified: incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java
>> URL: http://svn.apache.org/viewvc/incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java?rev=1569201&r1=1569200&r2=1569201&view=diff
>> ==============================================================================
>> --- incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java (original)
>> +++ incubator/sirona/trunk/core/src/main/java/org/apache/sirona/tracking/PathTrackingThreadLocal.java Tue Feb 18 05:59:35 2014
>> @@ -16,6 +16,8 @@
>> */
>> package org.apache.sirona.tracking;
>>
>> +import java.util.UUID;
>> +
>> /**
>> * @author Olivier Lamy
>> */
>> @@ -24,13 +26,14 @@ public class PathTrackingThreadLocal
>>
>> private static final boolean DEBUG = Boolean.getBoolean( "sirona.agent.debug" );
>>
>> +
>> //private static final InheritableThreadLocal<String> THREAD_LOCAL = new InheritableThreadLocal<String>()
>> private static final ThreadLocal<String> THREAD_LOCAL = new ThreadLocal<String>()
>> {
>> @Override
>> protected String initialValue()
>> {
>> - return "Sirona-" + System.nanoTime();// + UUID.randomUUID().toString();
>> + return "Sirona-" + UUID.randomUUID().toString();// + System.nanoTime();//
>> }
>>
>> /*
>>
>>
--
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy