You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2020/05/07 15:17:39 UTC
[Impala-ASF-CR] IMPALA-9722: Consolidate avg size calculation in PerColumnStats
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15878
Change subject: IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
......................................................................
IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
This change refactors the 'avg_size' calculation, 'total_width' will be
storing the sum of row widths till a Finalize call calculates the
average column size.
Testing:
- Added unit test to verify the aggregation result
Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
---
M be/src/exec/incr-stats-util-test.cc
M be/src/exec/incr-stats-util.cc
M be/src/exec/incr-stats-util.h
3 files changed, 27 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/15878/1
--
To view, visit http://gerrit.cloudera.org:8080/15878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
Gerrit-Change-Number: 15878
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-9722: Consolidate avg size calculation in PerColumnStats
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15878 )
Change subject: IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
......................................................................
IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
This change refactors the 'avg_size' calculation, 'total_width' will be
storing the sum of row widths till a Finalize call calculates the
average column size.
Testing:
- Added unit test to verify the aggregation result
Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
Reviewed-on: http://gerrit.cloudera.org:8080/15878
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M be/src/exec/incr-stats-util-test.cc
M be/src/exec/incr-stats-util.cc
M be/src/exec/incr-stats-util.h
3 files changed, 27 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Csaba Ringhofer: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
Gerrit-Change-Number: 15878
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9722: Consolidate avg size calculation in PerColumnStats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15878 )
Change subject: IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5791/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
Gerrit-Change-Number: 15878
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 12:23:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9722: Consolidate avg size calculation in PerColumnStats
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15878 )
Change subject: IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
Gerrit-Change-Number: 15878
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 May 2020 09:42:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9722: Consolidate avg size calculation in PerColumnStats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15878 )
Change subject: IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5991/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
Gerrit-Change-Number: 15878
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 16:11:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9722: Consolidate avg size calculation in PerColumnStats
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/15878 )
Change subject: IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
Gerrit-Change-Number: 15878
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 May 2020 17:20:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9722: Consolidate avg size calculation in PerColumnStats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15878 )
Change subject: IMPALA-9722: Consolidate avg_size calculation in PerColumnStats
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae1efb1c568c67dff6f25887c2ea2b8b249eea4b
Gerrit-Change-Number: 15878
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 May 2020 17:37:53 +0000
Gerrit-HasComments: No