You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <de...@geronimo.apache.org> on 2005/09/14 22:01:55 UTC

[jira] Created: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
-------------------------------------------------------------------------------------------------

         Key: GERONIMO-1012
         URL: http://issues.apache.org/jira/browse/GERONIMO-1012
     Project: Geronimo
        Type: Bug
  Components: Tomcat  
    Versions: 1.0-M5    
    Reporter: David Jencks
 Assigned to: David Jencks 
     Fix For: 1.0-M5


In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.

In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  

I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1012?page=all ]

David Jencks reassigned GERONIMO-1012:
--------------------------------------

    Assign To: Jeff Genender  (was: David Jencks)

Jeff, can you think of a better way to do this?

> Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
> -------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1012
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1012
>      Project: Geronimo
>         Type: Bug
>   Components: Tomcat
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: Jeff Genender
>      Fix For: 1.0-M5

>
> In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.
> In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  
> I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1012?page=all ]

John Sisson updated GERONIMO-1012:
----------------------------------

    Fix Version: 1.0.1
        Version: 1.0

> Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
> -------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1012
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1012
>      Project: Geronimo
>         Type: Bug
>   Components: Tomcat
>     Versions: 1.0-M5, 1.0
>     Reporter: David Jencks
>     Assignee: John Sisson
>      Fix For: 1.1, 1.0.1

>
> In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.
> In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  
> I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1012?page=all ]
     
John Sisson closed GERONIMO-1012:
---------------------------------

    Resolution: Fixed

> Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
> -------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1012
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1012
>      Project: Geronimo
>         Type: Bug
>   Components: Tomcat
>     Versions: 1.0-M5, 1.0
>     Reporter: David Jencks
>     Assignee: John Sisson
>      Fix For: 1.1, 1.0.1

>
> In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.
> In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  
> I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Reopened: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1012?page=all ]
     
David Jencks reopened GERONIMO-1012:
------------------------------------

     Assign To: David Jencks  (was: Jeff Genender)

As noted in one of the comments, the previous fix did not work for unprotected pages in a web-app with some secured pages.

> Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
> -------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1012
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1012
>      Project: Geronimo
>         Type: Bug
>   Components: Tomcat
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.
> In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  
> I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Posted by "Jeff Genender (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1012?page=all ]
     
Jeff Genender closed GERONIMO-1012:
-----------------------------------

    Resolution: Fixed

This works fine.  It probably could have been done in another Valve (like the policy conetxt valve), but this is a reasonable solution as well.  Thanks.

> Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
> -------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1012
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1012
>      Project: Geronimo
>         Type: Bug
>   Components: Tomcat
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: Jeff Genender
>      Fix For: 1.0-M5

>
> In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.
> In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  
> I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1012?page=comments#action_12329378 ] 

David Jencks commented on GERONIMO-1012:
----------------------------------------

I've fixed this for web apps that have no security constraints but are part of a secured j2ee application.  I don't see how to fix it for unsecured pages on web apps with constraints: it appears we'd have to rewrite/copy/modify the authentication valves.  I'm leaving this open in the hopes someone can find a better solution.

Sending        modules/tomcat/project.xml
Sending        modules/tomcat/src/java/org/apache/geronimo/tomcat/GeronimoStandardContext.java
Adding         modules/tomcat/src/java/org/apache/geronimo/tomcat/valve/DefaultSubjectValve.java
Sending        modules/tomcat/src/java/org/apache/geronimo/tomcat/valve/PolicyContextValve.java
Transmitting file data ....
Committed revision 289136.

> Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
> -------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1012
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1012
>      Project: Geronimo
>         Type: Bug
>   Components: Tomcat
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M5

>
> In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.
> In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  
> I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Reopened: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1012?page=all ]
     
John Sisson reopened GERONIMO-1012:
-----------------------------------

     Assign To: John Sisson  (was: David Jencks)

Need to apply to 1.0 branch

> Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
> -------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1012
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1012
>      Project: Geronimo
>         Type: Bug
>   Components: Tomcat
>     Versions: 1.0-M5, 1.0
>     Reporter: David Jencks
>     Assignee: John Sisson
>      Fix For: 1.1, 1.0.1

>
> In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.
> In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  
> I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1012) Tomcat integration does not set a subject in an unsecured web module in a secured ejb application

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1012?page=all ]
     
David Jencks closed GERONIMO-1012:
----------------------------------

    Fix Version: 1.1
                     (was: 1.0-M5)
     Resolution: Fixed

Jeff pointed out how to add the DefaultSubjectValve after the authentication valve.  This fixes the problems for unauthenticated pages in a secured web app.

Sending        modules/tomcat/src/java/org/apache/geronimo/tomcat/GeronimoStandardContext.java
Transmitting file data .
Committed revision 366121. 

> Tomcat integration does not set a subject in an unsecured web module in a secured ejb application
> -------------------------------------------------------------------------------------------------
>
>          Key: GERONIMO-1012
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1012
>      Project: Geronimo
>         Type: Bug
>   Components: Tomcat
>     Versions: 1.0-M5
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.1

>
> In the jetty integration, in SecurityContextBeforeAfter, a request for an unsecured page results in the default subject being set in the ContextManager (line 288).  This provides a way to call secured ejbs and also provides a source for credentials for calling secured web services.
> In tomcat, we don't do anything like that: in particular there is no source of credentials for secured web services.  
> I think the simplest solution is to, if the app is secured, to add another valve after the standard tomcat security valve, that sets the default subject into the ContextManager if none is there already.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira