You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by Andrew Purtell <ap...@apache.org> on 2009/12/31 21:57:03 UTC

Re: svn commit: r894799 - in /hadoop/hbase/branches/0.20

Hey Lars,

The patch fixes the bug as described, on visual inspection. I made sure no mapreduce package tests broke before commit but did not write a unit test for it. We could use one.

  - Andy



----- Original Message ----
> From: Lars George <la...@gmail.com>
> To: hbase-dev@hadoop.apache.org
> Cc: apurtell <ap...@apache.org>
> Sent: Thu, December 31, 2009 2:05:12 AM
> Subject: Re: svn commit: r894799 - in /hadoop/hbase/branches/0.20
> 
> Hi Andy,
> 
> Did this fix 
> http://www.mail-archive.com/hbase-user@hadoop.apache.org/msg07734.html
> ? I missed the issue and had not yet time to test this (as 0.20 does
> not have the junit 4 test). If so, does Sandy know already I assume?
> 
> Thanks,
> Lars

Re: svn commit: r894799 - in /hadoop/hbase/branches/0.20

Posted by Lars George <la...@gmail.com>.

Hi Andy,

We have a test in trunk. I will see if I fund time to check it way it  
did not find that edge case.

Lars

On Dec 31, 2009, at 21:57, Andrew Purtell <ap...@apache.org> wrote:

> Hey Lars,
>
> The patch fixes the bug as described, on visual inspection. I made  
> sure no mapreduce package tests broke before commit but did not  
> write a unit test for it. We could use one.
>
>  - Andy
>
>
>
> ----- Original Message ----
>> From: Lars George <la...@gmail.com>
>> To: hbase-dev@hadoop.apache.org
>> Cc: apurtell <ap...@apache.org>
>> Sent: Thu, December 31, 2009 2:05:12 AM
>> Subject: Re: svn commit: r894799 - in /hadoop/hbase/branches/0.20
>>
>> Hi Andy,
>>
>> Did this fix
>> http://www.mail-archive.com/hbase-user@hadoop.apache.org/ 
>> msg07734.html
>> ? I missed the issue and had not yet time to test this (as 0.20 does
>> not have the junit 4 test). If so, does Sandy know already I assume?
>>
>> Thanks,
>> Lars
>
>
>
>