You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/06/26 09:10:05 UTC
[GitHub] [cassandra] adejanovski opened a new pull request #653: Fix upgrade failures when using the EC2Snitch in legacy mode
adejanovski opened a new pull request #653:
URL: https://github.com/apache/cassandra/pull/653
Legacy naming conventions for AWS regions were allowing datacenter names such as us-west and us-west-2, which in the new standard mode become us-west-1 and us-west-2.
As us-west-2 can match both the standard and legacy mode, checking the DC name cannot be reliably used to detect mixed modes being used as it would fail in case of an upgrade from pre-4.0 clusters in a region such as us-west-2.
The rack check should be enough as rack names in the standard mode now includes the region name, which can be easily identified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a change in pull request #653: Fix upgrade failures when using the EC2Snitch in legacy mode
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on a change in pull request #653:
URL: https://github.com/apache/cassandra/pull/653#discussion_r446333602
##########
File path: test/unit/org/apache/cassandra/locator/EC2SnitchTest.java
##########
@@ -135,22 +135,6 @@ public void testFullNamingScheme() throws IOException, ConfigurationException
assertEquals("us-west-1a", snitch.getRack(local));
}
- @Test
- public void validateDatacenter_RequiresLegacy_CorrectAmazonName()
- {
- Set<String> datacenters = new HashSet<>();
- datacenters.add("us-east-1");
- Assert.assertFalse(Ec2Snitch.validate(datacenters, Collections.emptySet(), true));
- }
-
- @Test
- public void validateDatacenter_RequiresLegacy_LegacyName()
- {
- Set<String> datacenters = new HashSet<>();
- datacenters.add("us-east");
- Assert.assertTrue(Ec2Snitch.validate(datacenters, Collections.emptySet(), true));
- }
-
Review comment:
can we keep these tests, but change the verification?
(it's nice to see what it does, without having to run the code for real)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #653: Fix upgrade failures when using the EC2Snitch in legacy mode
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #653:
URL: https://github.com/apache/cassandra/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org