You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/05/31 20:50:40 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #41052: [SPARK-43380][SQL] Fix Avro data type conversion issues to avoid producing incorrect results
MaxGekk commented on code in PR #41052:
URL: https://github.com/apache/spark/pull/41052#discussion_r1212296225
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -3510,4 +3510,34 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
errorClass = "CANNOT_RENAME_ACROSS_SCHEMA", messageParameters = Map("type" -> "table")
)
}
+
+ def avroIncorrectTypeError(
+ avroPath: String, sqlPath: String, avroType: String,
+ sqlType: String, key: String): Throwable = {
+ new AnalysisException(
+ errorClass = "AVRO_INCORRECT_TYPE",
+ messageParameters = Map(
+ "avroPath" -> avroPath,
+ "sqlPath" -> sqlPath,
+ "avroType" -> avroType,
+ "sqlType" -> sqlType,
+ "key" -> key
+ )
+ )
+ }
+
+ def avroLowerPrecisionError(
+ avroPath: String, sqlPath: String, avroType: String,
+ sqlType: String, key: String): Throwable = {
+ new AnalysisException(
+ errorClass = "AVRO_LOWER_PRECISION",
+ messageParameters = Map(
+ "avroPath" -> avroPath,
+ "sqlPath" -> sqlPath,
+ "avroType" -> avroType,
+ "sqlType" -> sqlType,
Review Comment:
Please, wrap it by `toSQLType`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -3510,4 +3510,34 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
errorClass = "CANNOT_RENAME_ACROSS_SCHEMA", messageParameters = Map("type" -> "table")
)
}
+
+ def avroIncorrectTypeError(
+ avroPath: String, sqlPath: String, avroType: String,
+ sqlType: String, key: String): Throwable = {
+ new AnalysisException(
+ errorClass = "AVRO_INCORRECT_TYPE",
+ messageParameters = Map(
+ "avroPath" -> avroPath,
+ "sqlPath" -> sqlPath,
+ "avroType" -> avroType,
+ "sqlType" -> sqlType,
Review Comment:
Could you use `toSQLType` to quote the type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org