[GitHub] [superset] geido commented on a change in pull request #14664: fix: Fixes email body when sharing a chart by email

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #14664:
URL: https://github.com/apache/superset/pull/14664#discussion_r633728668



##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls/index.jsx
##########
@@ -266,6 +266,7 @@ class SliceHeaderControls extends React.PureComponent {
             copyMenuItemTitle={t('Copy chart URL')}
             emailMenuItemTitle={t('Share chart by email')}
             emailSubject={t('Superset chart')}
+            emailBody={t('Check out this chart: ')}

Review comment:
       Has anyone provided the copy? I am just wondering how do we go about copy in general when required. CC @rusackas 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org