You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2014/12/31 01:01:14 UTC
Review Request 29497: Add std::initializer_list to the whitelist of
C++11 features.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Add std::initializer_list to the whitelist of C++11 features.
Diffs
-----
docs/mesos-c++-style-guide.md 3cc9ecd3d8561840d74a6e46a3dbdedf932fec00
Diff: https://reviews.apache.org/r/29497/diff/
Testing
-------
Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
Thanks,
Michael Park
Re: Review Request 29497: Add std::initializer_list to the whitelist
of C++11 features.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/#review72944
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Feb. 17, 2015, 10:55 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29497/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add std::initializer_list to the whitelist of C++11 features.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md b24fe4b64a2577060f66ef49ae8b5d4a9d94167c
>
> Diff: https://reviews.apache.org/r/29497/diff/
>
>
> Testing
> -------
>
> Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29497: Add std::initializer_list to the whitelist
of C++11 features.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/#review72850
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29497]
All tests passed.
- Mesos ReviewBot
On Feb. 17, 2015, 10:55 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29497/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add std::initializer_list to the whitelist of C++11 features.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md b24fe4b64a2577060f66ef49ae8b5d4a9d94167c
>
> Diff: https://reviews.apache.org/r/29497/diff/
>
>
> Testing
> -------
>
> Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29497: Add std::initializer_list to the whitelist
of C++11 features.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/
-----------------------------------------------------------
(Updated Feb. 17, 2015, 10:55 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
Repository: mesos
Description
-------
Add std::initializer_list to the whitelist of C++11 features.
Diffs (updated)
-----
docs/mesos-c++-style-guide.md b24fe4b64a2577060f66ef49ae8b5d4a9d94167c
Diff: https://reviews.apache.org/r/29497/diff/
Testing
-------
Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
Thanks,
Michael Park
Re: Review Request 29497: Add std::initializer_list to the whitelist
of C++11 features.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/#review66431
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29497]
All tests passed.
- Mesos ReviewBot
On Dec. 31, 2014, 12:02 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29497/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 12:02 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add std::initializer_list to the whitelist of C++11 features.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 3cc9ecd3d8561840d74a6e46a3dbdedf932fec00
>
> Diff: https://reviews.apache.org/r/29497/diff/
>
>
> Testing
> -------
>
> Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29497: Add std::initializer_list to the whitelist
of C++11 features.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/#review66749
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Dec. 31, 2014, 12:02 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29497/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 12:02 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Add std::initializer_list to the whitelist of C++11 features.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 3cc9ecd3d8561840d74a6e46a3dbdedf932fec00
>
> Diff: https://reviews.apache.org/r/29497/diff/
>
>
> Testing
> -------
>
> Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29497: Add std::initializer_list to the whitelist
of C++11 features.
Posted by Michael Park <mc...@gmail.com>.
> On Feb. 15, 2015, 4:18 p.m., Alexander Rukletsov wrote:
> > docs/mesos-c++-style-guide.md, line 118
> > <https://reviews.apache.org/r/29497/diff/1/?file=803971#file803971line118>
> >
> > A minor nit here. All other list entries name the feature or language construct, which is "Initializer lists" in this case. Also note every entry ends in a period.
Fixed.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/#review72552
-----------------------------------------------------------
On Feb. 17, 2015, 10:55 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29497/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add std::initializer_list to the whitelist of C++11 features.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md b24fe4b64a2577060f66ef49ae8b5d4a9d94167c
>
> Diff: https://reviews.apache.org/r/29497/diff/
>
>
> Testing
> -------
>
> Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29497: Add std::initializer_list to the whitelist
of C++11 features.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/#review72552
-----------------------------------------------------------
docs/mesos-c++-style-guide.md
<https://reviews.apache.org/r/29497/#comment118601>
A minor nit here. All other list entries name the feature or language construct, which is "Initializer lists" in this case. Also note every entry ends in a period.
- Alexander Rukletsov
On Dec. 31, 2014, 12:02 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29497/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2014, 12:02 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add std::initializer_list to the whitelist of C++11 features.
>
>
> Diffs
> -----
>
> docs/mesos-c++-style-guide.md 3cc9ecd3d8561840d74a6e46a3dbdedf932fec00
>
> Diff: https://reviews.apache.org/r/29497/diff/
>
>
> Testing
> -------
>
> Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 29497: Add std::initializer_list to the whitelist
of C++11 features.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29497/
-----------------------------------------------------------
(Updated Dec. 31, 2014, 12:02 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
Repository: mesos-git
Description
-------
Add std::initializer_list to the whitelist of C++11 features.
Diffs
-----
docs/mesos-c++-style-guide.md 3cc9ecd3d8561840d74a6e46a3dbdedf932fec00
Diff: https://reviews.apache.org/r/29497/diff/
Testing
-------
Available since GCC-4.4 https://gcc.gnu.org/gcc-4.4/cxx0x_status.html
Thanks,
Michael Park