[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1617: [CELEBORN-708] Fix commit metrics in application heartbeat

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1617:
URL: https://github.com/apache/incubator-celeborn/pull/1617#discussion_r1236900949


##########
client/src/main/scala/org/apache/celeborn/client/ApplicationHeartbeater.scala:
##########
@@ -48,13 +48,14 @@ class ApplicationHeartbeater(
         override def run(): Unit = {
           try {
             require(rssHARetryClient != null, "When sending a heartbeat, client shouldn't be null.")
-            val (tmpTotalWritten, tmpFileCount) = shuffleMetrics()
-            logDebug(s"Send app heartbeat with $tmpTotalWritten $tmpFileCount")
+            val (tmpTotalWritten, tmpTotalFileCount) = shuffleMetrics()
+            logInfo("Send app heartbeat with " +

Review Comment:
   I suppose print it in each 10s is not noisy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org