You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/01/02 13:15:55 UTC
[PR] HDDS-10046. Replace PrecomputedVolumeSpace with SpaceUsageSource.Fixed [ozone]
adoroszlai opened a new pull request, #5904:
URL: https://github.com/apache/ozone/pull/5904
## What changes were proposed in this pull request?
`PrecomputedVolumeSpace`, added in HDDS-9380, is structurally very similar to the `Fixed` implementation of `SpaceUsageSource`. The latter is currently only used for testing. We can reduce duplication by moving `Fixed` from tests to production code and replacing `PrecomputedVolumeSpace` with it.
https://issues.apache.org/jira/browse/HDDS-10046
## How was this patch tested?
Refactoring, covered by existing tests:
https://github.com/adoroszlai/ozone/actions/runs/7385534327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10046. Replace PrecomputedVolumeSpace with SpaceUsageSource.Fixed [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5904:
URL: https://github.com/apache/ozone/pull/5904#issuecomment-1878241880
Thanks @sadanand48 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10046. Replace PrecomputedVolumeSpace with SpaceUsageSource.Fixed [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5904:
URL: https://github.com/apache/ozone/pull/5904#issuecomment-1874014521
@xichen01 please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10046. Replace PrecomputedVolumeSpace with SpaceUsageSource.Fixed [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5904:
URL: https://github.com/apache/ozone/pull/5904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org