[jira] [Commented] (LUCENE-3195) MockDirectoryWrapper should throw 'too many open files' if too many are open

["Shai Erera (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048377#comment-13048377 ] 

Shai Erera commented on LUCENE-3195:
------------------------------------

That's a great idea !

bq. and it should throw exception on openInput

and createOutput too?

bq. we should take a good default value

Let's just start w/ 1024? I doubt our tests need to open that many anyway, and it's, I think, low enough to fit any OS?

Also, and this can be added in future iterations, I think it'd be good if the exception includes a list of all test classes + count of open files, to make it easier to spot offending classes.

Hmmm ... now that I think of it, if our tests are run in different JVMs, we will fail to faithfully track the number of open file handles (I mean the *true* number)? In that case, we might want to lower the value to whatever we think a single JVM should allocate ... which gets tricky.

> MockDirectoryWrapper should throw 'too many open files' if too many are open
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-3195
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3195
>             Project: Lucene - Java
>          Issue Type: Test
>            Reporter: Robert Muir
>
> regardless of operating system.
> We should take a good default value, like the lowest one we consider 'reasonable' macosX? and it should throw exception on openInput if openFiles hashmap is too large.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org