You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ariatosca.apache.org by ran-z <gi...@git.apache.org> on 2017/05/03 14:17:19 UTC

[GitHub] incubator-ariatosca pull request #107: ARIA-148 CLI display commands

Github user ran-z commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/107#discussion_r114555739
  
    --- Diff: aria/cli/commands/service_templates.py ---
    @@ -181,21 +184,49 @@ def validate(service_template, service_template_filename,
         logger.info('Service template validated successfully')
     
     
    +@service_templates.command(name='display',
    +                           short_help='Display service template information')
    +@aria.argument('service-template-name')
    +@aria.options.verbose()
    +@aria.options.display_json
    +@aria.options.display_yaml
    +@aria.options.display_types
    +@aria.pass_model_storage
    +@aria.pass_logger
    +def display(service_template_name, model_storage, json, yaml, types, logger):
    --- End diff --
    
    Having both `display` and `show` is confusing :/
    I agree however that it doesn't make sense to make this command into a mere flag of `show` as they're very different.
    I'm generally ok with this as is, but Maxim wanted me to suggest `aria parse service/service-template` as an option as well. I'll leave it for your consideration :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---