You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/06/02 20:13:56 UTC
[GitHub] incubator-zeppelin pull request #953: ZEPPELIN-947: Change docs link to poin...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/953
ZEPPELIN-947: Change docs link to point the same Zeppelin version
### What is this PR for?
Currently, Zeppelin documentation link in Zeppelin home is pointing to http://zeppelin.apache.org/docs/latest/index.html. But maybe some people is not using the latest version. So the link should point to the same Zeppelin version that user is using now.
I just change the `latest` -> `{{zeppelinVersion}}`
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
[ZEPPELIN-947](https://issues.apache.org/jira/browse/ZEPPELIN-947)
### How should this be tested?
1. After applying this patch and browse Zeppelin home.
2. Just click `Zeppelin Documentation` link in here
<img width="357" alt="screen shot 2016-06-02 at 1 11 17 pm" src="https://cloud.githubusercontent.com/assets/10060731/15759461/8b69ee5c-28c3-11e6-8181-2fc2978c0297.png">
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-947
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/953.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #953
----
commit 4c7206707ecf2d5ba4a507b78a24a4e7090e9548
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-02T20:09:19Z
ZEPPELIN-947: Change docs link to point the same Zeppelin version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
I have seen in some of the organisations where the build/release team edits pom.xml and truncates `-SNAPSHOT` e.g. 0.6.0-SNAPSHOT becomes 0.6.0, for their own cache purposes.
So, IMO if we are going ahead with this, then may be we should have a redirect of http://zeppelin.apache.org/docs/{anything-else}/index.html to http://zeppelin.apache.org/docs/latest/index.html. Any thoughts ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
@prabhjyotsingh redirection is good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
The CI failure is unrelated,
Tested, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #953: ZEPPELIN-947: Change docs link to poin...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/953
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
@corneadoug updated #961, please check!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
but latest is generally older than the unreleased snapshot build?
for instance, https://zeppelin.incubator.apache.org/docs/latest/ now points to 0.5.6 release doc, not 0.6.0-snapshot doc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #953: ZEPPELIN-947: Change docs link to poin...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/953
ZEPPELIN-947: Change docs link to point the same Zeppelin version
### What is this PR for?
Currently, Zeppelin documentation link in Zeppelin home is pointing to http://zeppelin.apache.org/docs/latest/index.html. But maybe some people is not using the latest version. So the link should point to the same Zeppelin version that user is using now.
I just change the `latest` -> `{{zeppelinVersion}}`
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
[ZEPPELIN-947](https://issues.apache.org/jira/browse/ZEPPELIN-947)
### How should this be tested?
1. After applying this patch and browse Zeppelin home.
2. Just click `Zeppelin Documentation` link in here
<img width="357" alt="screen shot 2016-06-02 at 1 11 17 pm" src="https://cloud.githubusercontent.com/assets/10060731/15759461/8b69ee5c-28c3-11e6-8181-2fc2978c0297.png">
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin ZEPPELIN-947
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/953.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #953
----
commit 4c7206707ecf2d5ba4a507b78a24a4e7090e9548
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-06-02T20:09:19Z
ZEPPELIN-947: Change docs link to point the same Zeppelin version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
Right. This is good. I was not sure about the redirect comment above but I didn't really have a better solution.
_____________________________
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
LGTM. We can merge this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
@felixcheung Yeah right. As you can see, that's why I changed the link `http://zeppelin.apache.org/docs/latest/index.html` -> `http://zeppelin.apache.org/docs/{{zeppelinVersion}}/index.html`. Did I understand your comment incorrectly ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
@prabhjyotsingh Appreciate for sharing your thought! and
@Leemoonsoo Thanks for taking care that :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #953: ZEPPELIN-947: Change docs link to point the s...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
@Leemoonsoo not sure your PR is doing it, the idea was to use `latest` instead of `0.6.0-SNAPSHOT`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---