[jira] Commented: (TRINIDAD-758) failure in parsing of sub menu models (sharedNodes) results in root menu tree not being created. Bad sub menu models should just be skipped.

["Gary Kind (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TRINIDAD-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533196 ] 

Gary Kind commented on TRINIDAD-758:
------------------------------------

After code review by Jeanne Waldman, I have attached 2 new patch files that should be used.

> failure in parsing of sub menu models (sharedNodes) results in root menu tree not being created.  Bad sub menu models should just be skipped.
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-758
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-758
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>            Reporter: Gary Kind
>         Attachments: 122Branch.patch, 122Branch1.patch, trunk.patch
>
>
> If there is any kind of parsing error in a sub menu model's xml metadata OR the sub menu model creation returns a null XMLMenuModel, the creation of the root menu tree will break and not be created.  This should not happen.  The offending sub menu model should be skipped and the root menu tree should go on and be created without the offending sub menu model.  I have put code especially in MenuContentHandlerImpl.startElement, where a submenu  model is created upon encountering a <sharedNode> in the xml metadata, that handles a null XMLMenuModel or a sub menu model that had a parsing exception.   In either case, an exception is thrown but the root menu tree goes on being created.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.