You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/13 19:03:04 UTC
[GitHub] [kafka] ijuma opened a new pull request, #12635: MINOR: Mention that kraft is production ready in upgrade notes
ijuma opened a new pull request, #12635:
URL: https://github.com/apache/kafka/pull/12635
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio merged pull request #12635: MINOR: Mention that kraft is production ready in upgrade notes
Posted by GitBox <gi...@apache.org>.
jsancio merged PR #12635:
URL: https://github.com/apache/kafka/pull/12635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on a diff in pull request #12635: MINOR: Mention that kraft is production ready in upgrade notes
Posted by GitBox <gi...@apache.org>.
jsancio commented on code in PR #12635:
URL: https://github.com/apache/kafka/pull/12635#discussion_r970105135
##########
docs/upgrade.html:
##########
@@ -81,6 +81,8 @@ <h4><a id="upgrade_3_3_0" href="#upgrade_3_3_0">Upgrading a KRaft-based cluster
<h5><a id="upgrade_330_notable" href="#upgrade_330_notable">Notable changes in 3.3.0</a></h5>
<ul>
+ <li>KRaft mode is production ready for new clusters. See <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-833%3A+Mark+KRaft+as+Production+Ready">KIP-833</a>
Review Comment:
@ijuma should we use this URL https://cwiki.apache.org/confluence/x/8xKhD instead? This URL was generated using confluence share wiki feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on a diff in pull request #12635: MINOR: Mention that kraft is production ready in upgrade notes
Posted by GitBox <gi...@apache.org>.
jsancio commented on code in PR #12635:
URL: https://github.com/apache/kafka/pull/12635#discussion_r970110217
##########
docs/upgrade.html:
##########
@@ -81,6 +81,8 @@ <h4><a id="upgrade_3_3_0" href="#upgrade_3_3_0">Upgrading a KRaft-based cluster
<h5><a id="upgrade_330_notable" href="#upgrade_330_notable">Notable changes in 3.3.0</a></h5>
<ul>
+ <li>KRaft mode is production ready for new clusters. See <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-833%3A+Mark+KRaft+as+Production+Ready">KIP-833</a>
Review Comment:
The URL I pasted will never change. The URL with the KIP name can change if the author decides to change the name of the KIP. I forget how Confluence performs the redirect. I think in some cases I have seen Confluence to it automatically in other cases I have seen it suggest a different URL in the rendered webpage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on a diff in pull request #12635: MINOR: Mention that kraft is production ready in upgrade notes
Posted by GitBox <gi...@apache.org>.
jsancio commented on code in PR #12635:
URL: https://github.com/apache/kafka/pull/12635#discussion_r970110815
##########
docs/upgrade.html:
##########
@@ -81,6 +81,8 @@ <h4><a id="upgrade_3_3_0" href="#upgrade_3_3_0">Upgrading a KRaft-based cluster
<h5><a id="upgrade_330_notable" href="#upgrade_330_notable">Notable changes in 3.3.0</a></h5>
<ul>
+ <li>KRaft mode is production ready for new clusters. See <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-833%3A+Mark+KRaft+as+Production+Ready">KIP-833</a>
Review Comment:
> We don't use that for the other KIPs though.
I use that kind of URL when referencing KIPs but maybe others don't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #12635: MINOR: Mention that kraft is production ready in upgrade notes
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #12635:
URL: https://github.com/apache/kafka/pull/12635#discussion_r970107576
##########
docs/upgrade.html:
##########
@@ -81,6 +81,8 @@ <h4><a id="upgrade_3_3_0" href="#upgrade_3_3_0">Upgrading a KRaft-based cluster
<h5><a id="upgrade_330_notable" href="#upgrade_330_notable">Notable changes in 3.3.0</a></h5>
<ul>
+ <li>KRaft mode is production ready for new clusters. See <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-833%3A+Mark+KRaft+as+Production+Ready">KIP-833</a>
Review Comment:
We don't use that for the other KIPs though. Are the main advantages that it's shorter and handles renames better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org