You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Fedotov (JIRA)" <ji...@apache.org> on 2008/02/03 14:32:08 UTC

[jira] Created: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

[classlib][awt] reordering awt tests according to the testing convention
------------------------------------------------------------------------

                 Key: HARMONY-5451
                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Alexei Fedotov


The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.

> HUT test run:
> 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567323#action_12567323 ] 

Andrey Pavlenko commented on HARMONY-5451:
------------------------------------------

Tanks Alexei, I forgot to commit patches for the build files. Committed.

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Andrey Pavlenko
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko reassigned HARMONY-5451:
----------------------------------------

    Assignee: Andrey Pavlenko

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Andrey Pavlenko
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567316#action_12567316 ] 

Alexei Fedotov commented on HARMONY-5451:
-----------------------------------------

$ svn log modules/awt/build.xml | head
------------------------------------------------------------------------
r591101 | odeakin | 2007-11-01 21:07:21 +0300 (Thu, 01 Nov 2007) | 1 line

Some small changes to make sure that z/OS finds .x export libraries to link agai
nst.
------------------------------------------------------------------------
r574703 | ayza | 2007-09-12 01:39:43 +0400 (Wed, 12 Sep 2007) | 1 line

font.properties file for Windows XP/WS 2003 was added
------------------------------------------------------------------------



$ svn log modules/awt/make/hyproperties.xml | head
------------------------------------------------------------------------
r476395 | bayard | 2006-11-18 03:52:59 +0300 (Sat, 18 Nov 2006) | 1 line

Moving Harmony to TLP
------------------------------------------------------------------------
r451206 | hindessm | 2006-09-29 13:56:39 +0400 (Fri, 29 Sep 2006) | 1 line

Update source file headers in accordance with Foundation policy.
------------------------------------------------------------------------


> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Andrey Pavlenko
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov reopened HARMONY-5451:
-------------------------------------


Andrey, it seems that patches for the build system were not committed.

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Andrey Pavlenko
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov closed HARMONY-5451.
-----------------------------------

    Resolution: Fixed

Andrey, thanks!
Now a test report looks like expected.

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Andrey Pavlenko
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5451:
------------------------------------

    Attachment: build.patch

Submitted the patch instead of mistakenly submitted file.

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5451:
------------------------------------

    Attachment: make.patch

Sorry, forgot about property changes

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5451:
------------------------------------

    Attachment: build.xml
                impl.patch

Adapting patches.

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>         Attachments: build.xml, impl.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Pavlenko resolved HARMONY-5451.
--------------------------------------

    Resolution: Fixed

The patches have been applied. Please verify.

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Andrey Pavlenko
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5451:
------------------------------------

    Attachment: BufferedImageTest.java

Should be placed at working_classlib/modules/awt/src/test/api/java/org/apache/harmony/awt/tests/image/BufferedImageTest.java instead of both ImageDecoderTest instances (the latter should be removed, or $ less working_classlib/modules/awt/src/test/api/java/common/org/apache/harmony/awt/gl/image/ImageDecoderTest.java should be moved to this file)

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>         Attachments: BufferedImageTest.java, build.xml, impl.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567419#action_12567419 ] 

Alexei Fedotov commented on HARMONY-5451:
-----------------------------------------

Andrey, I'm sorry, but it seems that there should be done more work here.

The file modules/awt/src/test/impl/boot/org/apache/harmony/awt/tests/image/BufferedImageTest.java was intended to be at modules/awt/src/test/api/java/org/apache/harmony/awt/tests/image/BufferedImageTest.java since it was implementation independent. Could you please move the file?


> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Andrey Pavlenko
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5451:
------------------------------------

    Attachment:     (was: build.xml)

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>         Attachments: BufferedImageTest.java, impl.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5451:
------------------------------------

    Attachment: move.sh

Moving script. Somehow nested moves do not work well and prevent me from getting good svn diff.

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>         Attachments: move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5451) [classlib][awt] reordering awt tests according to the testing convention

Posted by "Andrey Pavlenko (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567422#action_12567422 ] 

Andrey Pavlenko commented on HARMONY-5451:
------------------------------------------

Moved.

> [classlib][awt] reordering awt tests according to the testing convention
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-5451
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5451
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexei Fedotov
>            Assignee: Andrey Pavlenko
>         Attachments: BufferedImageTest.java, build.patch, impl.patch, make.patch, move.sh
>
>
> The script and the patch reorder the tests in AWT class library module according to the class library testing convention. I have some problems to get nice diff: svn includes there all changes and will think if this can be improved. Also, some minor changes as replacement of two ImageDecoderTest instances with one BufferedImageTest were not scripted.
> > HUT test run:
> > 1804 0 0 100.00% 41.722 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.