You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MLnick <gi...@git.apache.org> on 2016/06/13 11:40:17 UTC
[GitHub] spark pull request #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ...
GitHub user MLnick opened a pull request:
https://github.com/apache/spark/pull/13641
[SPARK-10258][DOC][ML] Add @Since annotations to ml.feature
This PR adds missing `@Since` annotations to `ml.feature` package.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MLnick/spark add-since-annotations
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13641.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13641
----
commit a766bb06d8debb781227660072d083289018984c
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-03T22:54:12Z
Add @Since to Binarizer
commit 628602e5ae4c01912767adfa509d6be77756b660
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-03T23:50:22Z
Add @Since to Bucketizer
commit b99b61405adf9a9c5aac48f52837c7f701580ca5
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T20:08:23Z
Add @Since to ChiSqSelector
commit 4b86a54dd272aa22cb30fde2657bc1ff380f0f90
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T20:18:51Z
update ChiSqSelector and ChiSqSelectorModel annotations
commit 46efb6cabdedf9c220e946186900681abf66e8b0
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T20:19:49Z
Update Bucketizer annotations
commit 616ea42dfb42ca8ff528e9db9c8ba2cf8541eaed
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T20:27:38Z
Add @Since annotations for CountVectorizer and CountVectorizerModel
commit e1b1f88332137e7e803a669aa483cf9a0f9f72c1
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T20:31:48Z
Add @Since annotations for DCT
commit f4ff94c3459e60b400ddb9bcfa496be97b9cbcd2
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T20:34:39Z
Add @Since annotations for ElementWiseProduct
commit 5fe1fcbd996a286d038ccff3223ada3d23eef41e
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T20:42:57Z
Add @Since annotations for HashingTF
commit e86b78335dc3b7246159341e5f3442b7b01a604f
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T20:55:49Z
Add @Since annotations for IDF and IDFModel
commit d5767d96cb9c229443fe4aa9ae0ed7a49ee728c0
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T21:08:02Z
Update @Since annotations for Interaction
commit ae7e2543262326c0a8914745e264323c95a361e4
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-06T21:10:54Z
Update @Since annotations for MaxAbsScaler / MaxAbsScalerModel
commit 250d85d094a376a6708f219d01ac68a5744e3677
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:21:11Z
Update CountVectorizerModel annotations
commit e5458f073247008756bf598b9292bf27ce928bb0
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:25:01Z
Update HashingTF annotations
commit 1234ab940458c019ac5b7c44daa901d78abd0ebf
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:32:35Z
Add @Since annotations to MinMaxScaler and model
commit d7ca3085c5206a90dce6e88bd7905f00819e75a7
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:39:10Z
Add @Since annotations for NGram
commit 2982956eef39232bcd1a656996eb33f76ca34510
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:39:43Z
Update object annotations for max abs scaler
commit 34bf65a341b5f32062c433535fa70d43ae404f19
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:40:55Z
Update annotations for Bucketizer
commit aa94a5cffdc75cac23747a194b66c5c428676fa5
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:42:49Z
Add annotations for Normalizer
commit 78eee0c2fc08346581e2fb6ce3c70afed79a03c1
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:45:37Z
Add annotations for OneHotEncoder
commit 5da48cf67d7fa5b24279052301809123d3797281
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:52:33Z
Add @Since annotations for PCA
commit 22305a72f0a202abcb4581404179c7a80f4d7db0
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:53:49Z
Add @Since annotations for poly expansion
commit e791745c0f813e92c937bd0f2aff11bdbf321e69
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T09:55:30Z
Update annotations for quantile discretizer
commit 414cf2d8c856197a05f22e0dd080e7c931bc2b7b
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T10:00:05Z
Update annotations for RFormula
commit ebfed4f75838470c90a64f15b469cf3483d14816
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T10:00:35Z
Update annotations for SQLTransformer
commit 67b102105bf671e3331d2c675487d1ccbf929337
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T10:06:53Z
Add since annotations to standard scaler
commit 962e61906567564d41f52cf15828206d4dc9bd98
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T10:10:01Z
Add since annotations to stop words remover
commit f82414fdb4566eeddb6615239996ba7fefefa22e
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T10:22:00Z
Add since annotations to string indexer
commit 93c3eaff8b95887a78dcab3c754261b1803a3f99
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T10:28:12Z
Add since annotations to tokenizers
commit e01eee1090aab1c0aff67ed50b7d79972ad20286
Author: Nick Pentreath <ni...@za.ibm.com>
Date: 2016-06-13T10:34:01Z
Add since annotations to vector indezer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/13641#discussion_r67597362
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ElementwiseProduct.scala ---
@@ -33,21 +33,26 @@ import org.apache.spark.sql.types.DataType
* multiplier.
*/
@Experimental
-class ElementwiseProduct(override val uid: String)
+@Since("1.4.0")
+class ElementwiseProduct @Since("1.4.0") (@Since("1.4.0") override val uid: String)
extends UnaryTransformer[Vector, Vector, ElementwiseProduct] with DefaultParamsWritable {
+ @Since("1.4.0")
def this() = this(Identifiable.randomUID("elemProd"))
/**
* the vector to multiply with input vectors
* @group param
*/
+ @Since("1.4.0")
--- End diff --
good point, and also yeah technically all unary transformers over `Vector` should probably be since `2.0.0`. Will update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/13641#discussion_r67596150
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ElementwiseProduct.scala ---
@@ -33,21 +33,26 @@ import org.apache.spark.sql.types.DataType
* multiplier.
*/
@Experimental
-class ElementwiseProduct(override val uid: String)
+@Since("1.4.0")
+class ElementwiseProduct @Since("1.4.0") (@Since("1.4.0") override val uid: String)
extends UnaryTransformer[Vector, Vector, ElementwiseProduct] with DefaultParamsWritable {
+ @Since("1.4.0")
def this() = this(Identifiable.randomUID("elemProd"))
/**
* the vector to multiply with input vectors
* @group param
*/
+ @Since("1.4.0")
--- End diff --
This uses the new `Vector`. So ideally it is since `2.0.0`. I'm not sure about whether we should change the class since version to 2.0 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60842/consoleFull)** for PR 13641 at commit [`34b5f37`](https://github.com/apache/spark/commit/34b5f37d4a111a80c622fb7244ef54220e9167fd).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/13641#discussion_r67596152
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/ElementwiseProduct.scala ---
@@ -33,21 +33,26 @@ import org.apache.spark.sql.types.DataType
* multiplier.
*/
@Experimental
-class ElementwiseProduct(override val uid: String)
+@Since("1.4.0")
+class ElementwiseProduct @Since("1.4.0") (@Since("1.4.0") override val uid: String)
extends UnaryTransformer[Vector, Vector, ElementwiseProduct] with DefaultParamsWritable {
+ @Since("1.4.0")
def this() = this(Identifiable.randomUID("elemProd"))
/**
* the vector to multiply with input vectors
* @group param
*/
+ @Since("1.4.0")
val scalingVec: Param[Vector] = new Param(this, "scalingVec", "vector for hadamard product")
/** @group setParam */
+ @Since("1.4.0")
--- End diff --
ditto
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60699/consoleFull)** for PR 13641 at commit [`2fc676a`](https://github.com/apache/spark/commit/2fc676aafd8d5ceaa37cfae01cbd42ee41836fd2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/13641
cc @yanboliang @srowen @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60694/consoleFull)** for PR 13641 at commit [`86ab82b`](https://github.com/apache/spark/commit/86ab82b97d386bf8e1356640e2fb3e1a80d68014).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60700 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60700/consoleFull)** for PR 13641 at commit [`8c24513`](https://github.com/apache/spark/commit/8c24513b4e3179fa9773573e7513c6112faea4f9).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60402 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60402/consoleFull)** for PR 13641 at commit [`9978afa`](https://github.com/apache/spark/commit/9978afae05196f2c1463b93559781c6b35c69512).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class StandardScaler @Since(\"1.4.0\") (`
* `class Tokenizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60400 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60400/consoleFull)** for PR 13641 at commit [`3c8be11`](https://github.com/apache/spark/commit/3c8be11ab8adb93b3a847b5d6f407620d8d7cbf3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60401/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60401 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60401/consoleFull)** for PR 13641 at commit [`bb43722`](https://github.com/apache/spark/commit/bb4372217d2472772788573193b4288f285c3521).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `final class Binarizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `final class Bucketizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `final class ChiSqSelector @Since(\"1.6.0\") (@Since(\"1.6.0\") override val uid: String)`
* `class CountVectorizer @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`
* `class CountVectorizerModel(`
* `class DCT @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`
* `class ElementwiseProduct @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `class HashingTF @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `final class IDF @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `class Interaction @Since(\"1.6.0\") (@Since(\"1.6.0\") override val uid: String) extends Transformer`
* `class MaxAbsScaler @Since(\"2.0.0\") (@Since(\"2.0.0\") override val uid: String)`
* `class MinMaxScaler @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`
* `class NGram @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`
* `class Normalizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `class OneHotEncoder @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String) extends Transformer`
* `class PCA @Since(\"1.5.0\") (`
* `class PolynomialExpansion @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `final class QuantileDiscretizer @Since(\"1.6.0\") (@Since(\"1.6.0\") override val uid: String)`
* `class RFormula @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`
* `class SQLTransformer @Since(\"1.6.0\") (@Since(\"1.6.0\") override val uid: String) extends Transformer`
* `class StandardScaler @Since(\"1.2.0\") (`
* `class StopWordsRemover @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`
* `class StringIndexer @Since(\"1.4.0\") (`
* `class Tokenizer @Since(\"1.2.0\") (@Since(\"1.4.0\") override val uid: String)`
* `class RegexTokenizer @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `class VectorAssembler @Since(\"1.4.0\") (@Since(\"1.4.0\") override val uid: String)`
* `class VectorIndexer @Since(\"1.4.0\") (`
* `final class VectorSlicer @Since(\"1.5.0\") (@Since(\"1.5.0\") override val uid: String)`
* `final class Word2Vec @Since(\"1.4.0\") (`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60400/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60694/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60699/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13641
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60699/consoleFull)** for PR 13641 at commit [`2fc676a`](https://github.com/apache/spark/commit/2fc676aafd8d5ceaa37cfae01cbd42ee41836fd2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/13641
@yanboliang thanks - updated.
I also added annotations on overridden methods `transformSchema` and `copy`.
Let me know if I missed anything!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/13641
@mengxr I thought more about the `UnaryTransformer` cases, and I actually don't think it's necessary to bump the annotations for the classes, just the public methods/vals exposing `Vector`.
I thought the concrete classes would be binary incompatible but I don't actually think that is the case - and I just tested this (master against commit immediately prior to e2efe05) and apart from `scalingVec` it is fine.
I've created [SPARK-16127](https://issues.apache.org/jira/browse/SPARK-16127) to track further annotations that need updating related to new `ml.linalg` classes, and I think I will revert this particular change for `UnaryTransformer` classes in #13840.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/13641
@mengxr I went ahead and bumped all `UnaryTransformer[Vector, ...]` to `2.0.0`, as well as updating a few vals in some of the model classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13641#discussion_r67245105
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MaxAbsScaler.scala ---
@@ -88,7 +91,7 @@ class MaxAbsScaler @Since("2.0.0") (override val uid: String)
override def copy(extra: ParamMap): MaxAbsScaler = defaultCopy(extra)
}
-@Since("1.6.0")
+@Since("2.0.0")
object MaxAbsScaler extends DefaultParamsReadable[MaxAbsScaler] {
@Since("1.6.0")
--- End diff --
Not due to this PR, but here seems like a typo since ```MaxAbsScaler``` was added after 1.6.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60694 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60694/consoleFull)** for PR 13641 at commit [`86ab82b`](https://github.com/apache/spark/commit/86ab82b97d386bf8e1356640e2fb3e1a80d68014).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60400/consoleFull)** for PR 13641 at commit [`3c8be11`](https://github.com/apache/spark/commit/3c8be11ab8adb93b3a847b5d6f407620d8d7cbf3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60842/consoleFull)** for PR 13641 at commit [`34b5f37`](https://github.com/apache/spark/commit/34b5f37d4a111a80c622fb7244ef54220e9167fd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class ElementwiseProduct @Since(\"2.0.0\") (@Since(\"2.0.0\") override val uid: String)`
* `class Normalizer @Since(\"2.0.0\") (@Since(\"2.0.0\") override val uid: String)`
* `class PolynomialExpansion @Since(\"2.0.0\") (@Since(\"2.0.0\") override val uid: String)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13641#discussion_r67245508
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MaxAbsScaler.scala ---
@@ -88,7 +91,7 @@ class MaxAbsScaler @Since("2.0.0") (override val uid: String)
override def copy(extra: ParamMap): MaxAbsScaler = defaultCopy(extra)
}
-@Since("1.6.0")
+@Since("2.0.0")
object MaxAbsScaler extends DefaultParamsReadable[MaxAbsScaler] {
@Since("1.6.0")
--- End diff --
And in L174 and L177 should also be ```@Since("2.0.0")```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13641
@MLnick I found you did not add ```@Since``` for all params definition, is this as expected？I think we should add them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60700/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60401/consoleFull)** for PR 13641 at commit [`bb43722`](https://github.com/apache/spark/commit/bb4372217d2472772788573193b4288f285c3521).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60842/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60402 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60402/consoleFull)** for PR 13641 at commit [`9978afa`](https://github.com/apache/spark/commit/9978afae05196f2c1463b93559781c6b35c69512).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13641
**[Test build #60700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/60700/consoleFull)** for PR 13641 at commit [`8c24513`](https://github.com/apache/spark/commit/8c24513b4e3179fa9773573e7513c6112faea4f9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #13641: [SPARK-10258][DOC][ML] Add @Since annotations to ml.feat...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60402/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org