You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Alexander Kolbasov <ak...@cloudera.com> on 2017/10/12 07:48:16 UTC

Question about some ObjectStore code

Hello,

I noticed that there are some functions in ObjectStore (e.g. dropDatabase)
that do something like this:

...

success = commitTransaction();

...

return success;


The only case where commitTransaction returns false is when it was
rolled back already which is a pretty rare case.

In most cases, commitTransaction would simply throw some kind of
RuntimeException.

It looks the code that returns success status from commitTransaction()
is rather useless - does anyone know what is the thinking here?


- Alex