You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/05/27 21:15:52 UTC
[kudu-CR] apply ustat removal patch from llvm
sdrreynolds+gh@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13447
Change subject: apply ustat removal patch from llvm
......................................................................
apply ustat removal patch from llvm
Summary:
glib's sys/ustat.h has been deprecated for awhile and it has been
removed in glibc 2.28: https://lwn.net/Articles/761462/
The LLVM team merged the following into their project:
https://reviews.llvm.org/rG383fe5c8668f63ef21c646b43f48da9fa41aa100
and this is a port of that patch.
KUDU-2770
Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-ustat-removal.patch
2 files changed, 33 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/13447/1
--
To view, visit http://gerrit.cloudera.org:8080/13447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sd...@gmail.com>
[kudu-CR] KUDU-2770: apply ustat removal patch from llvm
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13447 )
Change subject: KUDU-2770: apply ustat removal patch from llvm
......................................................................
KUDU-2770: apply ustat removal patch from llvm
Summary:
glib's sys/ustat.h has been deprecated for awhile and it has been
removed in glibc 2.28: https://lwn.net/Articles/761462/
The LLVM team merged the following into their project:
https://reviews.llvm.org/rG383fe5c8668f63ef21c646b43f48da9fa41aa100
and this is a port of that patch.
Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
Reviewed-on: http://gerrit.cloudera.org:8080/13447
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-ustat-removal.patch
2 files changed, 59 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 3
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2770: apply ustat removal patch from llvm
Posted by "Scott Reynolds (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13447
to look at the new patch set (#2).
Change subject: KUDU-2770: apply ustat removal patch from llvm
......................................................................
KUDU-2770: apply ustat removal patch from llvm
Summary:
glib's sys/ustat.h has been deprecated for awhile and it has been
removed in glibc 2.28: https://lwn.net/Articles/761462/
The LLVM team merged the following into their project:
https://reviews.llvm.org/rG383fe5c8668f63ef21c646b43f48da9fa41aa100
and this is a port of that patch.
Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-ustat-removal.patch
2 files changed, 59 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/13447/2
--
To view, visit http://gerrit.cloudera.org:8080/13447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] apply ustat removal patch from llvm
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13447 )
Change subject: apply ustat removal patch from llvm
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13447/1/thirdparty/patches/llvm-ustat-removal.patch
File thirdparty/patches/llvm-ustat-removal.patch:
PS1:
Could you use the full patch with its git metadata? i.e. the entirety of what's in https://github.com/llvm/llvm-project/commit/383fe5c8668f63ef21c646b43f48da9fa41aa100? Makes it much easier to correlate with upstream later.
--
To view, visit http://gerrit.cloudera.org:8080/13447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 29 May 2019 18:29:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2770: apply ustat removal patch from llvm
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: KUDU-2770: apply ustat removal patch from llvm
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] apply ustat removal patch from llvm
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13447 )
Change subject: apply ustat removal patch from llvm
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13447/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13447/1//COMMIT_MSG@17
PS1, Line 17: KUDU-2770
nit: move this to the title line of the commit message
http://gerrit.cloudera.org:8080/#/c/13447/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
http://gerrit.cloudera.org:8080/#/c/13447/1/thirdparty/download-thirdparty.sh@321
PS1, Line 321: LLVM_PATCHLEVEL=2
this should be 3 now, right?
--
To view, visit http://gerrit.cloudera.org:8080/13447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 29 May 2019 04:18:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2770: apply ustat removal patch from llvm
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13447 )
Change subject: KUDU-2770: apply ustat removal patch from llvm
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13447
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I506f6031f39972bf9b9dbe3368214da2cf390830
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Reynolds <sd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 01 Jul 2019 17:15:11 +0000
Gerrit-HasComments: No