[GitHub] [lucene-solr] baisui1981 commented on a change in pull request #2343: SOLR-15100: make ConfigSetService configurable in solr.xml

[GitBox <gi...@apache.org>]

baisui1981 commented on a change in pull request #2343:
URL: https://github.com/apache/lucene-solr/pull/2343#discussion_r582434520



##########
File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java
##########
@@ -56,11 +58,24 @@
   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
   public static ConfigSetService createConfigSetService(NodeConfig nodeConfig, SolrResourceLoader loader, ZkController zkController) {
-    if (zkController == null) {
+
+    String configSetServiceClass = nodeConfig.getConfigSetServiceClass();
+
+    if(configSetServiceClass != null){
+      try {
+        Class<? extends ConfigSetService> clazz = loader.findClass(configSetServiceClass, ConfigSetService.class);
+        Constructor<? extends ConfigSetService> constructor

Review comment:
       do you mean that make the examining logic whether should use custome ConfigSetService creation  "configSetServiceClass != null"  move into NodeConfig?  And the creation of custome ConfigSetService instance should be move to other class?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org