You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Aleksey Shipilev (JIRA)" <ji...@apache.org> on 2007/08/31 12:30:30 UTC
[jira] Created: (HARMONY-4703) [drlvm][thread] minor
hythread_safe_point_other improvement
[drlvm][thread] minor hythread_safe_point_other improvement
-----------------------------------------------------------
Key: HARMONY-4703
URL: https://issues.apache.org/jira/browse/HARMONY-4703
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Reporter: Aleksey Shipilev
Current implementation of hythread_safe_point_other which is called from hythread_suspend_disable looks like this:
void VMCALL hythread_safe_point_other(hythread_t thread)
{
thread_safe_point_impl(tm_self_tls);
}
So, we are receiving hythread itself as the argument, then we throw it away and ask again for hythread_self via tm_self_tls alias.
We might throw away one TLS get then by simply passing thread downstream:
void VMCALL hythread_safe_point_other(hythread_t thread)
{
thread_safe_point_impl(thread);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4703) [drlvm][thread] minor
hythread_safe_point_other improvement
Posted by "Pavel Rebriy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554673 ]
Pavel Rebriy commented on HARMONY-4703:
---------------------------------------
The bug is fixed after commit of revision 606926 (HARMONY-4937).
> [drlvm][thread] minor hythread_safe_point_other improvement
> -----------------------------------------------------------
>
> Key: HARMONY-4703
> URL: https://issues.apache.org/jira/browse/HARMONY-4703
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Aleksey Shipilev
> Priority: Minor
> Attachments: HARMONY-4703.patch
>
>
> Current implementation of hythread_safe_point_other which is called from hythread_suspend_disable looks like this:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(tm_self_tls);
> }
> So, we are receiving hythread itself as the argument, then we throw it away and ask again for hythread_self via tm_self_tls alias.
> We might throw away one TLS get then by simply passing thread downstream:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(thread);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4703) [drlvm][thread] minor
hythread_safe_point_other improvement
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-4703.
--------------------------------------
Resolution: Fixed
Assignee: Gregory Shimansky
Ok closing this bug according to evaluation.
> [drlvm][thread] minor hythread_safe_point_other improvement
> -----------------------------------------------------------
>
> Key: HARMONY-4703
> URL: https://issues.apache.org/jira/browse/HARMONY-4703
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Aleksey Shipilev
> Assignee: Gregory Shimansky
> Priority: Minor
> Attachments: HARMONY-4703.patch
>
>
> Current implementation of hythread_safe_point_other which is called from hythread_suspend_disable looks like this:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(tm_self_tls);
> }
> So, we are receiving hythread itself as the argument, then we throw it away and ask again for hythread_self via tm_self_tls alias.
> We might throw away one TLS get then by simply passing thread downstream:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(thread);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4703) [drlvm][thread] minor
hythread_safe_point_other improvement
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-4703:
--------------------------------------
Priority: Minor (was: Major)
Patch Info: [Patch Available]
> [drlvm][thread] minor hythread_safe_point_other improvement
> -----------------------------------------------------------
>
> Key: HARMONY-4703
> URL: https://issues.apache.org/jira/browse/HARMONY-4703
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Aleksey Shipilev
> Priority: Minor
> Attachments: HARMONY-4703.patch
>
>
> Current implementation of hythread_safe_point_other which is called from hythread_suspend_disable looks like this:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(tm_self_tls);
> }
> So, we are receiving hythread itself as the argument, then we throw it away and ask again for hythread_self via tm_self_tls alias.
> We might throw away one TLS get then by simply passing thread downstream:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(thread);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4703) [drlvm][thread] minor
hythread_safe_point_other improvement
Posted by "Sergey Dmitriev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524322 ]
Sergey Dmitriev commented on HARMONY-4703:
------------------------------------------
Just wanted to make you know that this patch is OK with Oracle App Server startup.
> [drlvm][thread] minor hythread_safe_point_other improvement
> -----------------------------------------------------------
>
> Key: HARMONY-4703
> URL: https://issues.apache.org/jira/browse/HARMONY-4703
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Aleksey Shipilev
> Priority: Minor
> Attachments: HARMONY-4703.patch
>
>
> Current implementation of hythread_safe_point_other which is called from hythread_suspend_disable looks like this:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(tm_self_tls);
> }
> So, we are receiving hythread itself as the argument, then we throw it away and ask again for hythread_self via tm_self_tls alias.
> We might throw away one TLS get then by simply passing thread downstream:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(thread);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4703) [drlvm][thread] minor
hythread_safe_point_other improvement
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-4703:
--------------------------------------
Attachment: HARMONY-4703.patch
Patch is attached.
> [drlvm][thread] minor hythread_safe_point_other improvement
> -----------------------------------------------------------
>
> Key: HARMONY-4703
> URL: https://issues.apache.org/jira/browse/HARMONY-4703
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Aleksey Shipilev
> Attachments: HARMONY-4703.patch
>
>
> Current implementation of hythread_safe_point_other which is called from hythread_suspend_disable looks like this:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(tm_self_tls);
> }
> So, we are receiving hythread itself as the argument, then we throw it away and ask again for hythread_self via tm_self_tls alias.
> We might throw away one TLS get then by simply passing thread downstream:
> void VMCALL hythread_safe_point_other(hythread_t thread)
> {
> thread_safe_point_impl(thread);
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.