You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Animesh Chaturvedi <An...@citrix.com> on 2013/11/09 01:11:02 UTC
Review Request 15349: Overprivisoning changes needed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/
-----------------------------------------------------------
Review request for cloudstack and Nitin Mehta.
Bugs: Cloudstack-5077.
https://issues.apache.org/jira/browse/Cloudstack-5077.
Repository: cloudstack-git
Description
-------
1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4921925
server/src/com/cloud/configuration/Config.java f3cb919
Diff: https://reviews.apache.org/r/15349/diff/
Testing
-------
Thanks,
bharat kumar
Re: Review Request 15349: Overprivisoning changes needed
Posted by bharat kumar <bh...@citrix.com>.
> On Nov. 9, 2013, 12:36 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/configuration/Config.java, line 302
> > <https://reviews.apache.org/r/15349/diff/1/?file=380896#file380896line302>
> >
> > This needs to have corresponding upgrade fix as well.
This is the same as in 3.0.7, i think we need not have this in the upgrade.
> On Nov. 9, 2013, 12:36 a.m., Nitin Mehta wrote:
> > engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java, line 940
> > <https://reviews.apache.org/r/15349/diff/1/?file=380894#file380894line940>
> >
> > Do we have a way to correct it for folks already on 4.2 ?
> >
we will edit the fix_cpuovercommit script with these changes.
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28602
-----------------------------------------------------------
On Nov. 9, 2013, 12:11 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2013, 12:11 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4921925
> server/src/com/cloud/configuration/Config.java f3cb919
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28602
-----------------------------------------------------------
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
<https://reviews.apache.org/r/15349/#comment55463>
Do we have a way to correct it for folks already on 4.2 ?
server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/15349/#comment55462>
This needs to have corresponding upgrade fix as well.
- Nitin Mehta
On Nov. 9, 2013, 12:11 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2013, 12:11 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4921925
> server/src/com/cloud/configuration/Config.java f3cb919
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review30467
-----------------------------------------------------------
Facing the following error for diff 6
Nitins-MacBook-Air:cloudstack nitinmehta$ git apply 0001-Cloudstack-5077-reserve-cpu-and-memory-only-when.patch
error: patch failed: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:3007
error: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java: patch does not apply
- Nitin Mehta
On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 71894a8
> setup/db/db/schema-420to421.sql fe1e0d4
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review30469
-----------------------------------------------------------
Facing the following error for diff 6
Nitins-MacBook-Air:cloudstack nitinmehta$ git apply 0001-Cloudstack-5077-reserve-cpu-and-memory-only-when.patch
error: patch failed: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:3007
error: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java: patch does not apply
- Nitin Mehta
On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 71894a8
> setup/db/db/schema-420to421.sql fe1e0d4
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review30465
-----------------------------------------------------------
Facing the following error for diff 6
Nitins-MacBook-Air:cloudstack nitinmehta$ git apply 0001-Cloudstack-5077-reserve-cpu-and-memory-only-when.patch
error: patch failed: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:3007
error: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java: patch does not apply
- Nitin Mehta
On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 71894a8
> setup/db/db/schema-420to421.sql fe1e0d4
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review34389
-----------------------------------------------------------
Reminder -
Hi,
This review has been pending for long. Please take the time to address the raised issues.
Thanks!
- Amogh Vasekar
On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 71894a8
> setup/db/db/schema-420to421.sql fe1e0d4
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review30468
-----------------------------------------------------------
Facing the following error for diff 6
Nitins-MacBook-Air:cloudstack nitinmehta$ git apply 0001-Cloudstack-5077-reserve-cpu-and-memory-only-when.patch
error: patch failed: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:3007
error: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java: patch does not apply
- Nitin Mehta
On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 71894a8
> setup/db/db/schema-420to421.sql fe1e0d4
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review30466
-----------------------------------------------------------
Facing the following error for diff 6
Nitins-MacBook-Air:cloudstack nitinmehta$ git apply 0001-Cloudstack-5077-reserve-cpu-and-memory-only-when.patch
error: patch failed: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:3007
error: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java: patch does not apply
- Nitin Mehta
On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 71894a8
> setup/db/db/schema-420to421.sql fe1e0d4
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review30470
-----------------------------------------------------------
Facing the following error for diff 6
Nitins-MacBook-Air:cloudstack nitinmehta$ git apply 0001-Cloudstack-5077-reserve-cpu-and-memory-only-when.patch
error: patch failed: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java:3007
error: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java: patch does not apply
- Nitin Mehta
On Dec. 16, 2013, 12:32 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 71894a8
> setup/db/db/schema-420to421.sql fe1e0d4
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review42121
-----------------------------------------------------------
Ship it!
commit 99b4cf788eded0f6f155ff8cda51aeb2e505f764
- Kishan Kavala
On April 17, 2014, 10:01 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 10:01 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 82b6d84
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java c3a6b06
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e89777d
> setup/db/db/schema-420to421.sql 42e9c1e
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/
-----------------------------------------------------------
(Updated April 17, 2014, 4:31 a.m.)
Review request for cloudstack, Kishan Kavala and Nitin Mehta.
Bugs: Cloudstack-5077.
https://issues.apache.org/jira/browse/Cloudstack-5077.
Repository: cloudstack-git
Description
-------
1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 82b6d84
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java c3a6b06
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e89777d
setup/db/db/schema-420to421.sql 42e9c1e
Diff: https://reviews.apache.org/r/15349/diff/
Testing
-------
Thanks,
bharat kumar
Re: Review Request 15349: Overprivisoning changes needed
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 12:32 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
patch for master.
Bugs: Cloudstack-5077.
https://issues.apache.org/jira/browse/Cloudstack-5077.
Repository: cloudstack-git
Description
-------
1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 80497d4
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java 51fb0de
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 71894a8
setup/db/db/schema-420to421.sql fe1e0d4
Diff: https://reviews.apache.org/r/15349/diff/
Testing
-------
Thanks,
bharat kumar
Re: Review Request 15349: Overprivisoning changes needed
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 12:24 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
patch for 4.3
Bugs: Cloudstack-5077.
https://issues.apache.org/jira/browse/Cloudstack-5077.
Repository: cloudstack-git
Description
-------
1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java c2630b0
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d7eccc1
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java d5f3035
setup/db/db/schema-420to421.sql 302d44a
Diff: https://reviews.apache.org/r/15349/diff/
Testing
-------
Thanks,
bharat kumar
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28786
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On Nov. 13, 2013, 5:35 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 5:35 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4921925
> server/src/com/cloud/configuration/Config.java f06b463
> setup/db/db/schema-420to421.sql 302d44a
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 5:35 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Added the VMware resource changes.
Bugs: Cloudstack-5077.
https://issues.apache.org/jira/browse/Cloudstack-5077.
Repository: cloudstack-git
Description
-------
1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4921925
server/src/com/cloud/configuration/Config.java f06b463
setup/db/db/schema-420to421.sql 302d44a
Diff: https://reviews.apache.org/r/15349/diff/
Testing
-------
Thanks,
bharat kumar
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28745
-----------------------------------------------------------
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
<https://reviews.apache.org/r/15349/#comment55729>
Why are the changes to VmwareResource gone ?
Otherwise its a Ship it !!
- Nitin Mehta
On Nov. 12, 2013, 12:26 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2013, 12:26 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1
> server/src/com/cloud/configuration/Config.java f06b463
> setup/db/db/schema-420to421.sql baadbda
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/
-----------------------------------------------------------
(Updated Nov. 12, 2013, 12:26 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
added the update description commands in 4.2-4.2.1 sql file.
Bugs: Cloudstack-5077.
https://issues.apache.org/jira/browse/Cloudstack-5077.
Repository: cloudstack-git
Description
-------
1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1
server/src/com/cloud/configuration/Config.java f06b463
setup/db/db/schema-420to421.sql baadbda
Diff: https://reviews.apache.org/r/15349/diff/
Testing
-------
Thanks,
bharat kumar
Re: Review Request 15349: Overprivisoning changes needed
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/#review28667
-----------------------------------------------------------
server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/15349/#comment55585>
4.2 --> 4.2.1 upgrading folks will not see this text change
- Nitin Mehta
On Nov. 11, 2013, 10:03 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15349/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2013, 10:03 a.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: Cloudstack-5077.
> https://issues.apache.org/jira/browse/Cloudstack-5077.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
>
> 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
> 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
> engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1
> server/src/com/cloud/configuration/Config.java f06b463
>
> Diff: https://reviews.apache.org/r/15349/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request 15349: Overprivisoning changes needed
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15349/
-----------------------------------------------------------
(Updated Nov. 11, 2013, 10:03 a.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
added changes to update the memory overcommit in user_vm_details only in case of VMs running on VMware hypervisor.
Bugs: Cloudstack-5077.
https://issues.apache.org/jira/browse/Cloudstack-5077.
Repository: cloudstack-git
Description
-------
1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit.
2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading.
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java d37c0a1
server/src/com/cloud/configuration/Config.java f06b463
Diff: https://reviews.apache.org/r/15349/diff/
Testing
-------
Thanks,
bharat kumar