[jira] [Resolved] (THRIFT-5599) contrib/fb303 does not compile after C++ library refactorings

["Jens Geyer (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-5599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-5599.
--------------------------------
    Fix Version/s: 0.17.0
         Assignee: Michael Leinartas
       Resolution: Fixed

> contrib/fb303 does not compile after C++ library refactorings
> -------------------------------------------------------------
>
>                 Key: THRIFT-5599
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5599
>             Project: Thrift
>          Issue Type: Bug
>          Components: Contributed
>    Affects Versions: 0.13.0, 0.14.0, 0.15.0, 0.14.1, 0.14.2, 0.16.0
>            Reporter: Michael Leinartas
>            Assignee: Michael Leinartas
>            Priority: Minor
>             Fix For: 0.17.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> contrib/fb303 no longer compiles after THRIFT-4730 removed ReadWriteMutex.
> The ReadWriteMutex used by fb303 is protecting counter statistics. These are very write-heavy and read-light (these are read only when the Service methods getCounters() or getCounter() are called). Because of this, retaining a read-write mutex to protect these counters is unjustified and we can safely swap this out for a normal Mutex.
> Compilation also fails after THRIFT-5168 removed generation of *_constants.cpp and *_constants.h generation because the fb303 Makefile explicitly depends on these unnecessary files



--
This message was sent by Atlassian Jira
(v8.20.7#820007)