You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Edward Ribeiro (JIRA)" <ji...@apache.org> on 2017/03/25 04:34:41 UTC

[jira] [Comment Edited] (ZOOKEEPER-2739) maxClientCnxns not working in NettyServerCnxnFactory

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941564#comment-15941564 ] 

Edward Ribeiro edited comment on ZOOKEEPER-2739 at 3/25/17 4:34 AM:
--------------------------------------------------------------------

Hi [~vincentpoon], I have created a new PR for ZOOKEEPER-2280 and rebased it to current master. It also applies to branch-3.5, btw. The jira issue has the updated link now.

There are two review comments by [~fpj] yet to be addressed (I commented on new PR) and further review/tests. Gonna do that next, so that we can get this patch in asap. Any comment on PR is welcome in the meantime. :)


was (Author: eribeiro):
Hi [~vincentpoon], I have created a new PR and rebased it to current master. It also applies to branch-3.5. There are two review comments by [~fpj] yet to be addressed (I commented on new PR) and further review/tests. Gonna do that next. Any comment on PR is welcome in the meantime. :)

> maxClientCnxns not working in NettyServerCnxnFactory
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-2739
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2739
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.9, 3.5.0, 3.6.0
>            Reporter: Vincent Poon
>         Attachments: MaxNettyCnxnsTest.patch
>
>
> The maxClientCnxns field isn't being used in NettyServerCnxnFactory, and therefore the connection limit isn't observed.
> See attached test



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)