You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/18 03:09:22 UTC
[GitHub] [apisix] spacewander opened a new issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard
spacewander opened a new issue #6366:
URL: https://github.com/apache/apisix/issues/6366
### Issue description
feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard, so that we can solve the problem in https://github.com/apache/apisix/issues/6296 in a better way when:
1. the port in the Host header is checked
2. multiple nodes which have different host name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #6366:
URL: https://github.com/apache/apisix/issues/6366#issuecomment-1062448040
@wilson-1024
Would you like to work for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wilson-1024 commented on issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard
Posted by GitBox <gi...@apache.org>.
wilson-1024 commented on issue #6366:
URL: https://github.com/apache/apisix/issues/6366#issuecomment-1061457269
can we modify the host in (apisix/apisix/balancer.lua lines 333-340)?
```java
if pass_host == "node" and balancer.recreate_request then
local host = server.domain or server.host
if host ~= ctx.var.upstream_host then
-- retried node has a different host
ctx.var.upstream_host = host
header_changed = true
end
end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wilson-1024 commented on issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard
Posted by GitBox <gi...@apache.org>.
wilson-1024 commented on issue #6366:
URL: https://github.com/apache/apisix/issues/6366#issuecomment-1062553989
@spacewander Yes.I want to try to implement this function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #6366:
URL: https://github.com/apache/apisix/issues/6366#issuecomment-1061615999
Yes, and note that this part is retry.
You should also modify:
https://github.com/apache/apisix/blob/9b0460fb68e26d3fc1e8eac6659794598ce859ac/apisix/init.lua#L263-L265
And the standard port map can be found in https://github.com/apache/apisix/blob/9b0460fb68e26d3fc1e8eac6659794598ce859ac/apisix/upstream.lua#L170. (You might need to refactor it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #6366:
URL: https://github.com/apache/apisix/issues/6366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] wilson-1024 commented on issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard
Posted by GitBox <gi...@apache.org>.
wilson-1024 commented on issue #6366:
URL: https://github.com/apache/apisix/issues/6366#issuecomment-1061690595
ok.Thank you for your guidance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #6366: feat: As a User, I want to have the port in the Host header when `pass_host = node` and the port is not standard
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #6366:
URL: https://github.com/apache/apisix/issues/6366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org