You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Brian Lillie (JIRA)" <ji...@apache.org> on 2012/06/06 20:28:22 UTC
[jira] [Created] (SHINDIG-1791) BasicOAuth2Store client lookup
fails with sharedTokens set
Brian Lillie created SHINDIG-1791:
-------------------------------------
Summary: BasicOAuth2Store client lookup fails with sharedTokens set
Key: SHINDIG-1791
URL: https://issues.apache.org/jira/browse/SHINDIG-1791
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: 2.5.0-beta2, 2.5.0
Reporter: Brian Lillie
Fix For: 2.5.0-beta2
If an OAuth2 client is configured with sharedTokens, then when trying to set the token into the cache/persistence in the setToken method of the BasicOAuth2Store, the 'url' containing clientId:serviceName is passed to the getToken(...) method, rather than the actual gadget url. As a result, when getGadgetUri calls getClient, it will call using the clientId:serviceName as the URL, resulting in a client not found. Since the getGadgetUri returns the incoming URL if the client is not found, the code may still work, but for the wrong reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1791) BasicOAuth2Store client lookup
fails with sharedTokens set
Posted by "Stanton Sievers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stanton Sievers resolved SHINDIG-1791.
--------------------------------------
Resolution: Fixed
Fix Version/s: 2.5.0-beta2
Committed revision 1348118.
> BasicOAuth2Store client lookup fails with sharedTokens set
> ----------------------------------------------------------
>
> Key: SHINDIG-1791
> URL: https://issues.apache.org/jira/browse/SHINDIG-1791
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta2
> Reporter: Brian Lillie
> Fix For: 2.5.0-beta2
>
> Attachments: oauth2sharedtokens.patch
>
>
> If an OAuth2 client is configured with sharedTokens, then when trying to set the token into the cache/persistence in the setToken method of the BasicOAuth2Store, the 'url' containing clientId:serviceName is passed to the getToken(...) method, rather than the actual gadget url. As a result, when getGadgetUri calls getClient, it will call using the clientId:serviceName as the URL, resulting in a client not found. Since the getGadgetUri returns the incoming URL if the client is not found, the code may still work, but for the wrong reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1791) BasicOAuth2Store client lookup
fails with sharedTokens set
Posted by "Brian Lillie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291274#comment-13291274 ]
Brian Lillie commented on SHINDIG-1791:
---------------------------------------
Patch & review posted @ http://codereview.appspot.com/6305066/
> BasicOAuth2Store client lookup fails with sharedTokens set
> ----------------------------------------------------------
>
> Key: SHINDIG-1791
> URL: https://issues.apache.org/jira/browse/SHINDIG-1791
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta2
> Reporter: Brian Lillie
>
> If an OAuth2 client is configured with sharedTokens, then when trying to set the token into the cache/persistence in the setToken method of the BasicOAuth2Store, the 'url' containing clientId:serviceName is passed to the getToken(...) method, rather than the actual gadget url. As a result, when getGadgetUri calls getClient, it will call using the clientId:serviceName as the URL, resulting in a client not found. Since the getGadgetUri returns the incoming URL if the client is not found, the code may still work, but for the wrong reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1791) BasicOAuth2Store client lookup
fails with sharedTokens set
Posted by "Brian Lillie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Lillie updated SHINDIG-1791:
----------------------------------
Fix Version/s: (was: 2.5.0-beta2)
Affects Version/s: (was: 2.5.0)
> BasicOAuth2Store client lookup fails with sharedTokens set
> ----------------------------------------------------------
>
> Key: SHINDIG-1791
> URL: https://issues.apache.org/jira/browse/SHINDIG-1791
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta2
> Reporter: Brian Lillie
>
> If an OAuth2 client is configured with sharedTokens, then when trying to set the token into the cache/persistence in the setToken method of the BasicOAuth2Store, the 'url' containing clientId:serviceName is passed to the getToken(...) method, rather than the actual gadget url. As a result, when getGadgetUri calls getClient, it will call using the clientId:serviceName as the URL, resulting in a client not found. Since the getGadgetUri returns the incoming URL if the client is not found, the code may still work, but for the wrong reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1791) BasicOAuth2Store client lookup
fails with sharedTokens set
Posted by "Brian Lillie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Lillie updated SHINDIG-1791:
----------------------------------
Attachment: oauth2sharedtokens.patch
> BasicOAuth2Store client lookup fails with sharedTokens set
> ----------------------------------------------------------
>
> Key: SHINDIG-1791
> URL: https://issues.apache.org/jira/browse/SHINDIG-1791
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0-beta2
> Reporter: Brian Lillie
> Attachments: oauth2sharedtokens.patch
>
>
> If an OAuth2 client is configured with sharedTokens, then when trying to set the token into the cache/persistence in the setToken method of the BasicOAuth2Store, the 'url' containing clientId:serviceName is passed to the getToken(...) method, rather than the actual gadget url. As a result, when getGadgetUri calls getClient, it will call using the clientId:serviceName as the URL, resulting in a client not found. Since the getGadgetUri returns the incoming URL if the client is not found, the code may still work, but for the wrong reasons.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira