You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2019/12/17 21:59:28 UTC

[Bug 64013] New: build.xml "release" target fails due to JavaDoc warnings

https://bz.apache.org/bugzilla/show_bug.cgi?id=64013

            Bug ID: 64013
           Summary: build.xml "release" target fails due to JavaDoc
                    warnings
           Product: Tomcat 8
           Version: 8.5.50
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Packaging
          Assignee: dev@tomcat.apache.org
          Reporter: stanchev@hotmail.com
  Target Milestone: ----

Trying to build TC 8.5.50 from source using "release" ant target fails with due
to JavaDoc warnings on src\java\org\apache\catalina\realm\RealmBase.java:

  [javadoc] Loading source files for package org.apache.tomcat.jdbc.pool...
  [javadoc] Loading source files for package
org.apache.tomcat.jdbc.pool.interceptor...
  [javadoc] Loading source files for package org.apache.tomcat.jdbc.pool.jmx...
  [javadoc] Constructing Javadoc information...
  [javadoc] Standard Doclet version 1.8.0_232
  [javadoc] Building tree for all the packages and classes...
  [javadoc] D:\work\My
Projects\java\Tomcat\8.5.50-src\output\dist\src\java\org\apache\catalina\realm\RealmBase.java:1253:
warning: no @param for username
  [javadoc]     protected Principal getPrincipal(String username,
  [javadoc]                         ^
  [javadoc] D:\work\My
Projects\java\Tomcat\8.5.50-src\output\dist\src\java\org\apache\catalina\realm\RealmBase.java:1253:
warning: no @param for gssCredential
  [javadoc]     protected Principal getPrincipal(String username,
  [javadoc]                         ^
  [javadoc] D:\work\My
Projects\java\Tomcat\8.5.50-src\output\dist\src\java\org\apache\catalina\realm\RealmBase.java:1253:
warning: no @return
  [javadoc]     protected Principal getPrincipal(String username,
  [javadoc]                         ^
  [javadoc] Building index for all the packages and classes...
  [javadoc] Building index for all classes...
  [javadoc] Generating D:\work\My
Projects\java\Tomcat\8.5.50-src\output\dist\webapps\docs\api\help-doc.html...
  [javadoc] 3 warnings

BUILD FAILED
D:\work\My Projects\java\Tomcat\8.5.50-src\build.xml:2010: Javadoc issued
warnings.

Total time: 2 minutes 10 seconds

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64013] build.xml "release" target fails due to JavaDoc warnings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64013

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
We'll get this fixed (we're aiming to get the release builds working with all
Java versions from the minimum required for each Tomcat version to whatever the
latest is - 14 early access as I write this).

Just for the record, the Tomcat 8.5.x releases are built with Java 7 which is
less strict which is why this wasn't spotted during the release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64013] build.xml "release" target fails due to JavaDoc warnings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64013

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
You should be able to do a release build with any supported Java version for
8.5.x now.

And for the record:

9.0.x was OK.

7.0.x is still a work in progress. There are a large number of Javadoc warnings
to resolve is using newer versions of Java.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 64013] build.xml "release" target fails due to JavaDoc warnings

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64013

--- Comment #2 from George Stanchev <st...@hotmail.com> ---
Yeah I forgot to mention that I used Java 8u232 for the build. The fix is
trivial of course. I added the javadoc elements below and it finished building

   /**
     * @deprecated This will be removed in Tomcat 10. Use
     *             {@link #getPrincipal(GSSName, GSSCredential)} instead.
     * @param username The user name
     * @param gssCredential the GSS credential of the principal
     * @return the Principal associated with the given user name.
     */
    @Deprecated
    protected Principal getPrincipal(String username,
            GSSCredential gssCredential) {
        Principal p = getPrincipal(username);

        if (p instanceof GenericPrincipal) {
            ((GenericPrincipal) p).setGssCredential(gssCredential);
        }

        return p;
    }

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org