[GitHub] rahul003 opened a new pull request #8880: correct usage of bool arguments from command line

[GitBox <gi...@apache.org>]

rahul003 opened a new pull request #8880: correct usage of bool arguments from command line
URL: https://github.com/apache/incubator-mxnet/pull/8880
 
 
   ## Description ##
   When trying to convert any non empty string to bool, python returns True. 
   > bool('False') 
   > True
   
   This means if a bool argument (`--shuffle`) has a default value of True, then passing `--shuffle False` will not set it to true. 
   
   Correcting this by converting the string argument given to bool with a custom function. 
   
   This is a fix with minimal change on user's end. Alternative (and the proper way) would be `--shuffle` and `--no-shuffle`. But that would require significant changes to the examples.
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Passed code style checking (`make lint`)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented. 
   - [ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ## Comments ##
   - Refer description above
   - Fixes issues people have raised like https://github.com/apache/incubator-mxnet/issues/8875

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services