[GitHub] [geode] PurelyApplied opened pull request #2995: GEODE-6198: Add geode-all-bom for dependency versioning

["PurelyApplied (GitHub)" <gi...@apache.org>]

* All modules refer to the BOM to determine dependency versions.
* Consequently, all JavaCompile tasks depend on the BOM.
* Remove explicit versioning from dependency declarations
* Unify plugin / classpath styles.
* Use RELEASE of Sprint Dependency Management, not RC.
* Also move eclipse configurations outside of dependency blocks, as they
are unrelated.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2995 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2995: GEODE-6198: Add geode-all-bom for dependency versioning

["PurelyApplied (GitHub)" <gi...@apache.org>]

@dickcav Upon further inspection, [the Wiki](https://cwiki.apache.org/confluence/display/GEODE/License+Guide+for+Contributors) says that the build runtime *is* in fact meant to be in the bundle.  So no foul on that front!

[ Full content available at: https://github.com/apache/geode/pull/2995 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied closed pull request #2995: GEODE-6198: Add geode-all-bom for dependency versioning

["PurelyApplied (GitHub)" <gi...@apache.org>]

[ pull request closed by PurelyApplied ]

[ Full content available at: https://github.com/apache/geode/pull/2995 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #2995: GEODE-6198: Add geode-all-bom for dependency versioning

["PurelyApplied (GitHub)" <gi...@apache.org>]

There are multiple "cleanups" that could be part of this or a near-future PR.  Part of me wanted to kick off testing sooner rather than later, though.

(Probably yet part of this PR:)

* Multiple same-version `dependency` lines should be collapsed to a `dependencySet`.
* The application of the `dependencyManagement { imports {...` could be part of a "plugin" and applied via `apply from: ...`.  This should also subsume the remaining `dependency-versions.properties` to keep them all in one place.  The `JavaCompile` task dependency should live there as well.

(Probably future PRs:)

* The version of project components should not be explicit in the POM and also specified in the BOM.  Stripping versioning from project dependencies was found in itself to be nontrivial.
* How we're handling Jetty and Tomcat should be examined before it is clear if or how they should be part of the BOM.

[ Full content available at: https://github.com/apache/geode/pull/2995 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org