[GitHub] merlimat commented on a change in pull request #1702: Allow to configure TLS hostname verification in PulsarAdmin

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #1702: Allow to configure TLS hostname verification in PulsarAdmin
URL: https://github.com/apache/incubator-pulsar/pull/1702#discussion_r185344966
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java
 ##########
 @@ -46,6 +46,13 @@
     @Parameter(names = { "--auth-params" }, description = "Authentication parameters, e.g., \"key1:val1,key2:val2\".")
     String authParams = null;
 
+    @Parameter(names = { "--tls-allow-insecure" }, description = "Allow TLS insecure connection")
+    Boolean tlsAllowInsecureConnection;
+
+
+    @Parameter(names = { "--tls-enable-hostname-verification" }, description = "Enalbe TLS common name verification")
+    Boolean tlsEnableHostnameVerification;
 
 Review comment:
   yes, probably, but it should be consistent with the same setting on client library, which is currently default to false

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services