You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/22 02:41:31 UTC
[GitHub] [airflow] Juacall opened a new pull request #21029: TrinoHookImprovement
Juacall opened a new pull request #21029:
URL: https://github.com/apache/airflow/pull/21029
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
The Trino hook requires a username and password to use the hook. If i were to try to use a connection without it, it would error out asking for basic authentication or a trino user. If i add a username and password to a connection. The connection becomes encrypted and is added to secrets then i won't be able to discover it unless i go through the basehook.
conn = BaseHook.get_connection(kwargs['my_conn_id'])
There are flaws in both systems that causes the inconsistency with the TrinoHook when using Basic Authentication. This will allow a connection from secrets to be passed to TrinoHook but will not fix the problem with TrinoHook Basic Authentication. Basic Authentication will not work with a Http connection and Airflow does not allow you to send a https connection without using a uri.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1019594761
https://github.com/Juacall/airflow/tree/master
> This branch is 1 commit ahead, 40 commits behind apache:main.
Please rebase to latest main: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id15
The "40 commits behind" matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1086423932
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Juacall commented on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
Juacall commented on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1019023236
I don't know what the up to date issue is. I fetched the upstream and edited that to make sure it was up to date. Rebase said everything was up to date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1019594761
https://github.com/Juacall/airflow/tree/master
> https://github.com/Juacall/airflow/tree/master
Please rebase to latest main: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Juacall removed a comment on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
Juacall removed a comment on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1019023236
I don't know what the up to date issue is. I fetched the upstream and edited that to make sure it was up to date. Rebase said everything was up to date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1040056047
I'm not sure I fully understand the issue.
According to you using login and password does work as expected. Your problem is that you don't see the password but this is expected. So what is the real issue here?
I'm using Presto provider (which for that matter is the same as Trino) and I have no troubles with authenticating (I guess that whatever needs to be fixed for Trino will be the same for Presto)
Could you please provide more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1040056047
I'm not sure I fully understand the issue.
According to you using login and password does work as expected. Your problem is that you don't see the password but this is expected. So what is the real issue here?
I'm using Presto provider (which for that matter is the same as Trino) and I have no troubles with authenticating (I guess that whatever needs to be fixed for Trino will be the same for Presto)
Could you please provide more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1019594761
Look at: https://github.com/Juacall/airflow/tree/master
> This branch is 1 commit ahead, 40 commits behind apache:main.
Please rebase to latest **apache** main: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id15
The "40 commits behind" matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1019594761
Look at: https://github.com/Juacall/airflow/tree/master
> This branch is 1 commit ahead, 40 commits behind apache:main.
Please rebase to latest main: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id15
The "40 commits behind" matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #21029: TrinoHookImprovement
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #21029:
URL: https://github.com/apache/airflow/pull/21029#issuecomment-1019594761
https://github.com/Juacall/airflow/tree/master
> This branch is 1 commit ahead, 40 commits behind apache:main.
Please rebase to latest main: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org