You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Pranav Khaitan (JIRA)" <ji...@apache.org> on 2010/09/16 10:19:34 UTC

[jira] Created: (HBASE-3005) Add reseek optimization for fetching multiple versions via TimestampsFilter

Add reseek optimization for fetching multiple versions via TimestampsFilter
---------------------------------------------------------------------------

                 Key: HBASE-3005
                 URL: https://issues.apache.org/jira/browse/HBASE-3005
             Project: HBase
          Issue Type: Improvement
          Components: filters
            Reporter: Pranav Khaitan
            Assignee: Pranav Khaitan


Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.

For example:

If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-3005) Add reseek optimization for fetching multiple versions via TimestampsFilter

Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910762#action_12910762 ] 

HBase Review Board commented on HBASE-3005:
-------------------------------------------

Message from: "Ryan Rawson" <ry...@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/859/#review1261
-----------------------------------------------------------

Ship it!


lgtm

- Ryan





> Add reseek optimization for fetching multiple versions via TimestampsFilter
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-3005
>                 URL: https://issues.apache.org/jira/browse/HBASE-3005
>             Project: HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Pranav Khaitan
>            Assignee: Pranav Khaitan
>         Attachments: HBASE-PUBLIC-3005-V1.patch
>
>
> Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.
> For example:
> If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-3005) Add reseek optimization for fetching multiple versions via TimestampsFilter

Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910235#action_12910235 ] 

HBase Review Board commented on HBASE-3005:
-------------------------------------------

Message from: stack@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/859/#review1244
-----------------------------------------------------------

Ship it!


+1

Ryan, you want to take a look since you've got your head in here?

- stack





> Add reseek optimization for fetching multiple versions via TimestampsFilter
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-3005
>                 URL: https://issues.apache.org/jira/browse/HBASE-3005
>             Project: HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Pranav Khaitan
>            Assignee: Pranav Khaitan
>         Attachments: HBASE-PUBLIC-3005-V1.patch
>
>
> Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.
> For example:
> If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-3005) Add reseek optimization for fetching multiple versions via TimestampsFilter

Posted by "Pranav Khaitan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranav Khaitan updated HBASE-3005:
----------------------------------

    Attachment: HBASE-PUBLIC-3005-V1.patch

The code for this is put up for review at https://review.cloudera.org/r/859/

> Add reseek optimization for fetching multiple versions via TimestampsFilter
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-3005
>                 URL: https://issues.apache.org/jira/browse/HBASE-3005
>             Project: HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Pranav Khaitan
>            Assignee: Pranav Khaitan
>         Attachments: HBASE-PUBLIC-3005-V1.patch
>
>
> Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.
> For example:
> If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-3005) Add reseek optimization for fetching multiple versions via TimestampsFilter

Posted by "Kannan Muthukkaruppan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910054#action_12910054 ] 

Kannan Muthukkaruppan commented on HBASE-3005:
----------------------------------------------

Note: This applies when we use the TimestampsFilter() to fetch a specified set of versions.

Patch looks good to me. Jonathan/Ryan: please review/approve. Thanks.

> Add reseek optimization for fetching multiple versions via TimestampsFilter
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-3005
>                 URL: https://issues.apache.org/jira/browse/HBASE-3005
>             Project: HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Pranav Khaitan
>            Assignee: Pranav Khaitan
>         Attachments: HBASE-PUBLIC-3005-V1.patch
>
>
> Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.
> For example:
> If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-3005) Add reseek optimization for fetching multiple versions via TimestampsFilter

Posted by "Pranav Khaitan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pranav Khaitan resolved HBASE-3005.
-----------------------------------

    Resolution: Fixed

This was resolved and committed some time back.

> Add reseek optimization for fetching multiple versions via TimestampsFilter
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-3005
>                 URL: https://issues.apache.org/jira/browse/HBASE-3005
>             Project: HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Pranav Khaitan
>            Assignee: Pranav Khaitan
>         Attachments: HBASE-PUBLIC-3005-V1.patch
>
>
> Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.
> For example:
> If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-3005) Add reseek optimization for fetching multiple versions via TimestampsFilter

Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910057#action_12910057 ] 

HBase Review Board commented on HBASE-3005:
-------------------------------------------

Message from: "Pranav Khaitan" <pr...@facebook.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/859/
-----------------------------------------------------------

Review request for hbase and Kannan Muthukkaruppan.


Summary
-------

Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.

For example:

If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.


This addresses bug HBASE-3005.
    http://issues.apache.org/jira/browse/HBASE-3005


Diffs
-----

  trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java 997639 
  trunk/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java 997639 

Diff: http://review.cloudera.org/r/859/diff


Testing
-------

All tests using TimestampFilter passing

Reviewed by Kannan


Thanks,

Pranav




> Add reseek optimization for fetching multiple versions via TimestampsFilter
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-3005
>                 URL: https://issues.apache.org/jira/browse/HBASE-3005
>             Project: HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Pranav Khaitan
>            Assignee: Pranav Khaitan
>         Attachments: HBASE-PUBLIC-3005-V1.patch
>
>
> Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.
> For example:
> If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-3005) Add reseek optimization for fetching multiple versions via TimestampsFilter

Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910056#action_12910056 ] 

HBase Review Board commented on HBASE-3005:
-------------------------------------------

Message from: "Kannan Muthukkaruppan" <ka...@facebook.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/859/#review1241
-----------------------------------------------------------

Ship it!


Nice!

- Kannan





> Add reseek optimization for fetching multiple versions via TimestampsFilter
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-3005
>                 URL: https://issues.apache.org/jira/browse/HBASE-3005
>             Project: HBase
>          Issue Type: Improvement
>          Components: filters
>            Reporter: Pranav Khaitan
>            Assignee: Pranav Khaitan
>         Attachments: HBASE-PUBLIC-3005-V1.patch
>
>
> Skip between timestamps to avoid the unnecessary read for all the blocks which come in between.
> For example:
> If we have timestamps from 1 to 1000 for a particular row, family, qualifier and we want to read only timestamps 990 and 10, then we should be able to read 990 and then jump to 10 instead of doing a sequential read including everything in between.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.