You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mbalassi <gi...@git.apache.org> on 2015/03/20 18:38:21 UTC
[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...
GitHub user mbalassi opened a pull request:
https://github.com/apache/flink/pull/506
[FLINK-1756] [streaming] Rename Stream Monitoring to Stream Checkpointing
Also set the default checkpoint interval to 1 sec instead of 10.
@senorcarbone, @gyfora please let me know if I have forgotten something when renaming.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink flink-1756
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/506.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #506
----
commit 51c7ef1ab39bda1723136000fd49ae0f5c95bcce
Author: mbalassi <mb...@apache.org>
Date: 2015-03-20T15:06:56Z
[FLINK-1756] [streaming] Rename Stream Monitoring to Stream Checkpointing
Also set the default checkpoint interval to 1 sec instead of 10.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...
Posted by senorcarbone <gi...@git.apache.org>.
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84596628
:+1: nice
Another thing, while you are at it. What about changing the compaction timeout. It is currently set to 2 x interval which might be an overkill for big intervals. Perhaps it should be a constant one instead or triggered on demand upon getting acknowledgements
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84591454
1 sec seems to be little to frequent until we make this very efficient. I would put it around 3-5 sec.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84591515
Other than this, it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...
Posted by mbalassi <gi...@git.apache.org>.
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84633164
@gyfora: Changed default checkpoint interval to 5 secs.
@senorcarbone: Thanks for the reminder on that. I do not have a really nice idea for the compaction interval right now. It does not make much sense to have a constant as there might not be anything to compact if we have too rare checkpoints.
The on-demand one can be nice eventually, but I think the current should be good enough for now - we are not expected to store large state anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...
Posted by derSascha <gi...@git.apache.org>.
Github user derSascha commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-85720375
Looks like the JobGraph missed the renaming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/506
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1756] [streaming] Rename Stream Monitor...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/506#issuecomment-84687727
Change looks good.
I miss some javadocs on the user facing methods ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---