You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alexandr Antonenko <hi...@gmail.com> on 2014/12/22 18:45:35 UTC

Review Request 29318: View: Files, cleanup and rendering optimization

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29318/
-----------------------------------------------------------

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-8799
    https://issues.apache.org/jira/browse/AMBARI-8799


Repository: ambari


Description
-------

Files view rendering of directories with many files is slow and needs to be improved.


Diffs
-----

  contrib/views/files/src/main/resources/ui/app/adapter.js ff98a10 
  contrib/views/files/src/main/resources/ui/app/assets/javascripts/ember-qunit.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/javascripts/jquery.mockjax.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/javascripts/modernizr-2.6.2.min.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/javascripts/qunit.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/javascripts/tests.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/stylesheets/qunit.css PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/assets/tests.html PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/components/breadCrumbs.js 8448f05 
  contrib/views/files/src/main/resources/ui/app/components/bulkCheckbox.js 34c9a1f 
  contrib/views/files/src/main/resources/ui/app/components/chmodInput.js 151b681 
  contrib/views/files/src/main/resources/ui/app/components/confirmDelete.js e0122bf 
  contrib/views/files/src/main/resources/ui/app/components/contextMenu.js c35b485 
  contrib/views/files/src/main/resources/ui/app/components/popoverDelete.js bd398df 
  contrib/views/files/src/main/resources/ui/app/components/renameInput.js cd311e9 
  contrib/views/files/src/main/resources/ui/app/components/sortArrow.js 7c4a4e4 
  contrib/views/files/src/main/resources/ui/app/components/toggleContext.js 326fa64 
  contrib/views/files/src/main/resources/ui/app/components/uploader.js 5837c36 
  contrib/views/files/src/main/resources/ui/app/controllers/chmodModal.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/controllers/error.js ecf7749 
  contrib/views/files/src/main/resources/ui/app/controllers/file.js 7992814 
  contrib/views/files/src/main/resources/ui/app/controllers/files.js 8de6a4b 
  contrib/views/files/src/main/resources/ui/app/controllers/filesAlert.js f2ef6b6 
  contrib/views/files/src/main/resources/ui/app/initialize.js 8b79492 
  contrib/views/files/src/main/resources/ui/app/models/file.js 2a8c83c 
  contrib/views/files/src/main/resources/ui/app/routes/file.js 5df1c0b 
  contrib/views/files/src/main/resources/ui/app/styles/application.less c44923e 
  contrib/views/files/src/main/resources/ui/app/templates/components/contextMenu.hbs aa86ed1 
  contrib/views/files/src/main/resources/ui/app/templates/components/mkdirInput.hbs 0db9240 
  contrib/views/files/src/main/resources/ui/app/templates/files.hbs 76c439d 
  contrib/views/files/src/main/resources/ui/app/templates/modal/chmod.hbs PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/templates/util/errorRow.hbs 1a1e920 
  contrib/views/files/src/main/resources/ui/app/templates/util/fileRow.hbs 7f69041 
  contrib/views/files/src/main/resources/ui/app/views/file.js 167f70f 
  contrib/views/files/src/main/resources/ui/app/views/files.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/app/views/modalChmod.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/config.coffee b7bc79f 
  contrib/views/files/src/main/resources/ui/package.json 8ff13e5 
  contrib/views/files/src/main/resources/ui/runner.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/test/spec.coffee ecf0374 
  contrib/views/files/src/main/resources/ui/test/unit/controllers/files_test.js PRE-CREATION 
  contrib/views/files/src/main/resources/ui/vendor/js/ember-cloaking.js PRE-CREATION 
  pom.xml 5d55074 

Diff: https://reviews.apache.org/r/29318/diff/


Testing
-------


Thanks,

Alexandr Antonenko

Re: Review Request 29318: View: Files, cleanup and rendering optimization

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29318/#review65795
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Гру. 22, 2014, 5:45 після полудня, Alexandr Antonenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29318/
> -----------------------------------------------------------
> 
> (Updated Гру. 22, 2014, 5:45 після полудня)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-8799
>     https://issues.apache.org/jira/browse/AMBARI-8799
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Files view rendering of directories with many files is slow and needs to be improved.
> 
> 
> Diffs
> -----
> 
>   contrib/views/files/src/main/resources/ui/app/adapter.js ff98a10 
>   contrib/views/files/src/main/resources/ui/app/assets/javascripts/ember-qunit.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/javascripts/jquery.mockjax.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/javascripts/modernizr-2.6.2.min.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/javascripts/qunit.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/javascripts/tests.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/stylesheets/qunit.css PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/assets/tests.html PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/components/breadCrumbs.js 8448f05 
>   contrib/views/files/src/main/resources/ui/app/components/bulkCheckbox.js 34c9a1f 
>   contrib/views/files/src/main/resources/ui/app/components/chmodInput.js 151b681 
>   contrib/views/files/src/main/resources/ui/app/components/confirmDelete.js e0122bf 
>   contrib/views/files/src/main/resources/ui/app/components/contextMenu.js c35b485 
>   contrib/views/files/src/main/resources/ui/app/components/popoverDelete.js bd398df 
>   contrib/views/files/src/main/resources/ui/app/components/renameInput.js cd311e9 
>   contrib/views/files/src/main/resources/ui/app/components/sortArrow.js 7c4a4e4 
>   contrib/views/files/src/main/resources/ui/app/components/toggleContext.js 326fa64 
>   contrib/views/files/src/main/resources/ui/app/components/uploader.js 5837c36 
>   contrib/views/files/src/main/resources/ui/app/controllers/chmodModal.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/controllers/error.js ecf7749 
>   contrib/views/files/src/main/resources/ui/app/controllers/file.js 7992814 
>   contrib/views/files/src/main/resources/ui/app/controllers/files.js 8de6a4b 
>   contrib/views/files/src/main/resources/ui/app/controllers/filesAlert.js f2ef6b6 
>   contrib/views/files/src/main/resources/ui/app/initialize.js 8b79492 
>   contrib/views/files/src/main/resources/ui/app/models/file.js 2a8c83c 
>   contrib/views/files/src/main/resources/ui/app/routes/file.js 5df1c0b 
>   contrib/views/files/src/main/resources/ui/app/styles/application.less c44923e 
>   contrib/views/files/src/main/resources/ui/app/templates/components/contextMenu.hbs aa86ed1 
>   contrib/views/files/src/main/resources/ui/app/templates/components/mkdirInput.hbs 0db9240 
>   contrib/views/files/src/main/resources/ui/app/templates/files.hbs 76c439d 
>   contrib/views/files/src/main/resources/ui/app/templates/modal/chmod.hbs PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/templates/util/errorRow.hbs 1a1e920 
>   contrib/views/files/src/main/resources/ui/app/templates/util/fileRow.hbs 7f69041 
>   contrib/views/files/src/main/resources/ui/app/views/file.js 167f70f 
>   contrib/views/files/src/main/resources/ui/app/views/files.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/app/views/modalChmod.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/config.coffee b7bc79f 
>   contrib/views/files/src/main/resources/ui/package.json 8ff13e5 
>   contrib/views/files/src/main/resources/ui/runner.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/test/spec.coffee ecf0374 
>   contrib/views/files/src/main/resources/ui/test/unit/controllers/files_test.js PRE-CREATION 
>   contrib/views/files/src/main/resources/ui/vendor/js/ember-cloaking.js PRE-CREATION 
>   pom.xml 5d55074 
> 
> Diff: https://reviews.apache.org/r/29318/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Antonenko
> 
>