You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "clolov (via GitHub)" <gi...@apache.org> on 2023/08/01 13:57:55 UTC

[GitHub] [kafka] clolov commented on a diff in pull request #13260: KAFKA-14661: Upgrade Zookeeper to 3.8.1

clolov commented on code in PR #13260:
URL: https://github.com/apache/kafka/pull/13260#discussion_r1280689006


##########
build.gradle:
##########
@@ -893,6 +893,10 @@ project(':core') {
       implementation libs.dropwizardMetrics
       exclude module: 'slf4j-log4j12'
       exclude module: 'log4j'
+      // ZooKeeper moved from log4j to logback in v3.8.0,
+      // but Kafka relies on log4j. We are removing this additional dependency.

Review Comment:
   Yup, this is the exact reason. Kafka uses slf4j + reload4j. Zookeeper uses slf4j + logback. When we remove logback we fallback to reload4j for both Zookeeper and Kafka. I will update the comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org