[GitHub] [dolphinscheduler] lenboo commented on a change in pull request #8347: [Fix-8337] [Master] Process instance can not be kill when task is failure and can be retry

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #8347:
URL: https://github.com/apache/dolphinscheduler/pull/8347#discussion_r810081695



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/StateWheelExecuteThread.java
##########
@@ -134,6 +134,14 @@ private void checkTask4Retry() {
         }
 
         for (TaskInstance taskInstance : this.taskInstanceRetryCheckList.values()) {
+            ProcessInstance processInstance = processService.findProcessInstanceById(taskInstance.getProcessInstanceId());
+
+            if (processInstance.getState() == ExecutionStatus.READY_STOP) {

Review comment:
       This 'READY_STOP' state will be send to master from API, so is it necessary to query from the database again？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org