[GitHub] [incubator-superset] john-bodley opened a new pull request #7573: [ad-hoc] Fixing type for COUNT DISTINCT

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #7573: [ad-hoc] Fixing type for COUNT DISTINCT
URL: https://github.com/apache/incubator-superset/pull/7573
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR fixes an issue with ad-hoc metrics using the Druid REST API related to `COUNT DISTINCT`. Specifically per the [documentation](http://druid.io/docs/latest/querying/hll-old.html) the type should be `hyperUnique` when 
   
   > ... that has been aggregated as a "hyperUnique" metric at indexing time.
   
   as opposed to `cardinality`. Both use HyperLogLog however the former is specific to Druid metrics which are of type `hyperUnique` (per the indexing aggregation) vs computing the cardinality of non-complex types.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A
   
   ### TEST PLAN
   
   CI.
   
   ### REVIEWERS
   
   to: @gabe-lyons @michellethomas @mistercrunch 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org