Re: [PR] chore: add pull request template [incubator-fury]

["chaokunyang (via GitHub)" <gi...@apache.org>]

chaokunyang commented on code in PR #1477:
URL: https://github.com/apache/incubator-fury/pull/1477#discussion_r1555679320


##########
.github/pull_request_template.md:
##########
@@ -0,0 +1,42 @@
+<!--
+**Thanks for contributing to Fury.**
+
+**If this is your first time opening a PR on fury, you can refer to [CONTRIBUTING.md](https://github.com/apache/incubator-fury/blob/main/CONTRIBUTING.md).**
+
+Contribution Checklist
+
+    - The **Apache Fury (incubating)** community has restrictions on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/incubator-fury/blob/main/CONTRIBUTING.md).
+
+    - Fury does not accept PRs that degrade performance. If the PR you submit will have an impact on performance, please Benchmark it yourself first.

Review Comment:
   ```suggestion
       - Fury has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here.
   ```
   I personly feel `Fury does not accept PRs that degrade performance` is a little aggressive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org