You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/05/05 15:44:47 UTC

[GitHub] [systemds] Baunsgaard commented on pull request #1237: [SYSTEMDS-2604] Federated Output for AggregateBinaryFEDInstruction

Baunsgaard commented on pull request #1237:
URL: https://github.com/apache/systemds/pull/1237#issuecomment-832800326


   > I am not completely convinced that the latest commit is an improvement.
   > What do you think, @Baunsgaard ?
   
   i don't like it either.
   
   Why not allow the two federated ranges to be equal if the arrays are the same and they are both overlapping?
   then you don't have to care about the hash of this element, making the implementation cleaner.
   In general why does the ranges need to implement comparable, if it is just for sorting then allowing them to be equal is fine.
   
   also you added more of the PART, rather than rewording it to overlap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org