You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-commits@perl.apache.org by ge...@apache.org on 2006/03/07 18:47:44 UTC

svn commit: r383939 - in /perl/Apache-Test/trunk/t: conf/extra.conf.in next_available_port.t

Author: geoff
Date: Tue Mar  7 09:47:42 2006
New Revision: 383939

URL: http://svn.apache.org/viewcvs?rev=383939&view=rev
Log:
wrap SetEnv calls with <IfModule mod_env.c>
http://rt.cpan.org/Ticket/Display.html?id=18039

Modified:
    perl/Apache-Test/trunk/t/conf/extra.conf.in
    perl/Apache-Test/trunk/t/next_available_port.t

Modified: perl/Apache-Test/trunk/t/conf/extra.conf.in
URL: http://svn.apache.org/viewcvs/perl/Apache-Test/trunk/t/conf/extra.conf.in?rev=383939&r1=383938&r2=383939&view=diff
==============================================================================
--- perl/Apache-Test/trunk/t/conf/extra.conf.in (original)
+++ perl/Apache-Test/trunk/t/conf/extra.conf.in Tue Mar  7 09:47:42 2006
@@ -38,7 +38,9 @@
   </Directory>
 
   # t/next_available_port.t
-  SetEnv NextAvailablePort @NextAvailablePort@
+  <IfModule mod_env.c>
+    SetEnv NextAvailablePort @NextAvailablePort@
+  </IfModule>
 
 </IfModule>
 

Modified: perl/Apache-Test/trunk/t/next_available_port.t
URL: http://svn.apache.org/viewcvs/perl/Apache-Test/trunk/t/next_available_port.t?rev=383939&r1=383938&r2=383939&view=diff
==============================================================================
--- perl/Apache-Test/trunk/t/next_available_port.t (original)
+++ perl/Apache-Test/trunk/t/next_available_port.t Tue Mar  7 09:47:42 2006
@@ -7,7 +7,7 @@
 use Apache::TestRequest;
 use Apache::TestUtil;
 
-plan tests => 1, need_cgi;
+plan tests => 1, need need_cgi, need_module('env');
 
 my $url = '/cgi-bin/next_available_port.pl';
 



Re: svn commit: r383939 - in /perl/Apache-Test/trunk/t: conf/extra.conf.in next_available_port.t

Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Thanks Geoff.

:)

>> +  <IfModule mod_env.c>
>> +    SetEnv NextAvailablePort @NextAvailablePort@
>> +  </IfModule>
> 
> 
> Check the svnview output for this one: it doesn't escape [<>] chars in
> the html output:
> http://svn.apache.org/viewcvs.cgi/perl/Apache-Test/trunk/t/conf/extra.conf.in?rev=383939&view=diff&r1=383939&r2=383938&p1=perl/Apache-Test/trunk/t/conf/extra.conf.in&p2=/perl/Apache-Test/trunk/t/conf/extra.conf.in

heh.

someone should commit a file with some xss hack in it that spits out
pro-Apache-Test propaganda :)

--Geoff

Re: svn commit: r383939 - in /perl/Apache-Test/trunk/t: conf/extra.conf.in next_available_port.t

Posted by Stas Bekman <st...@stason.org>.
geoff@apache.org wrote:
> Author: geoff
> Date: Tue Mar  7 09:47:42 2006
> New Revision: 383939
> 
> URL: http://svn.apache.org/viewcvs?rev=383939&view=rev
> Log:
> wrap SetEnv calls with <IfModule mod_env.c>
> http://rt.cpan.org/Ticket/Display.html?id=18039

Thanks Geoff.

> Modified: perl/Apache-Test/trunk/t/conf/extra.conf.in
> URL: http://svn.apache.org/viewcvs/perl/Apache-Test/trunk/t/conf/extra.conf.in?rev=383939&r1=383938&r2=383939&view=diff
> ==============================================================================
> --- perl/Apache-Test/trunk/t/conf/extra.conf.in (original)
> +++ perl/Apache-Test/trunk/t/conf/extra.conf.in Tue Mar  7 09:47:42 2006
> @@ -38,7 +38,9 @@
>    </Directory>
>  
>    # t/next_available_port.t
> -  SetEnv NextAvailablePort @NextAvailablePort@
> +  <IfModule mod_env.c>
> +    SetEnv NextAvailablePort @NextAvailablePort@
> +  </IfModule>

Check the svnview output for this one: it doesn't escape [<>] chars in the 
html output:
http://svn.apache.org/viewcvs.cgi/perl/Apache-Test/trunk/t/conf/extra.conf.in?rev=383939&view=diff&r1=383939&r2=383938&p1=perl/Apache-Test/trunk/t/conf/extra.conf.in&p2=/perl/Apache-Test/trunk/t/conf/extra.conf.in


-- 
_____________________________________________________________
Stas Bekman mailto:stas@stason.org  http://stason.org/
MailChannels: Assured Messaging(TM) http://mailchannels.com/
The "Practical mod_perl" book       http://modperlbook.org/
http://perl.apache.org/ http://perl.org/ http://logilune.com/