[GitHub] [airflow] potiuk commented on pull request #23979: Add `PrestoToSlackOperator`

[GitBox <gi...@apache.org>]

potiuk commented on PR #23979:
URL: https://github.com/apache/airflow/pull/23979#issuecomment-1146235832

   I am a bit torn on that one. I think it's fine to keep it is as is (in "presto" provider), but I have some doubt I wanted to share.
   
   First thought is that this operator should really be part of "Slack" provider as this is the "Target".  this is mostly what we chose for most  "transfer" operators and there "target" is usualy more interested in "maintaining" the operator. 
   
   However in this case believe the "maintainability" rule favours Presto over Slack. Slack can be seen as utility/notification rather than "transfer" side.
   
   
   https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#naming-conventions-for-provider-packages 
   
   >  It is often debatable where to put transfer operators but we agreed to the following criteria:
   > We use "maintainability" of the operators as the main criteria - so the transfer operator should be kept at the provider which has highest "interest" in the transfer operator
   > For Cloud Providers or Service providers that usually means that the transfer operators should land at the "target" side of the transfer
   
   Do you also see it that way @eladkal ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org