[GitHub] spark pull request #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Us...

[jerryshao <gi...@git.apache.org>]

Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20119#discussion_r159364034
  
    --- Diff: common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java ---
    @@ -94,9 +93,9 @@ public ByteBuffer nioByteBuffer() throws IOException {
     
       @Override
       public InputStream createInputStream() throws IOException {
    -    InputStream is = null;
    +    FileInputStream is = null;
         try {
    -      is = Files.newInputStream(file.toPath());
    +      is = new FileInputStream(file);
           ByteStreams.skipFully(is, offset);
           return new LimitedInputStream(is, length);
    --- End diff --
    
    I think this two lines might be the place which suffers from `skip` issue, can we just only revert this place? @zsxwing @cloud-fan @gatorsmile .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org